From: Richard Biener <richard.guenther@gmail.com>
To: Eric Botcazou <botcazou@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Use default lower bound for vector types in debug info
Date: Mon, 4 Jul 2022 11:08:53 +0200 [thread overview]
Message-ID: <CAFiYyc3cP6y7UNyOyXZ_tJWfXUd40c=YffF33uR_c8iNGj868w@mail.gmail.com> (raw)
In-Reply-To: <3176742.aeNJFYEL58@fomalhaut>
On Mon, Jul 4, 2022 at 10:42 AM Eric Botcazou <botcazou@adacore.com> wrote:
>
> > For late generated vector types this might result in inconsistencies with
> > early (user) generated types when using LTO.
>
> Is that a problem? That's no different with regular array types.
I'm not sure - almost all types the user can actually inspect should have early
debug info.
> > Is there context available somehow so we can do like the is_<LANG> overloads
> > on a decl and use a default according to that?
>
> Not sure, the only safe thing to do would be to return -1 as the default lower
> bound if flag_generate_lto.
Rather if in_lto_p, but yes, this sounds like a good thing to do. OTOH if
the used language is uniform LTO will pick that, it will "merge" C/C++
and otherwise use C as fallback in a mixed environment.
So the patch is quite likely OK as-is.
Which means .. OK.
Thanks,
Richard.
> --
> Eric Botcazou
>
>
prev parent reply other threads:[~2022-07-04 9:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 7:52 Eric Botcazou
2022-07-04 8:18 ` Richard Biener
2022-07-04 8:42 ` Eric Botcazou
2022-07-04 9:08 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc3cP6y7UNyOyXZ_tJWfXUd40c=YffF33uR_c8iNGj868w@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).