From: Richard Biener <richard.guenther@gmail.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] toplev.c: set FILE * globals to NULL after fclose
Date: Wed, 10 Aug 2016 10:15:00 -0000 [thread overview]
Message-ID: <CAFiYyc3e4yjCY_5HcZ1tZC8Ujgpi1dVe1Un=U8BOHS8cf4V0=w@mail.gmail.com> (raw)
In-Reply-To: <1470792304-8431-1-git-send-email-dmalcolm@redhat.com>
On Wed, Aug 10, 2016 at 3:25 AM, David Malcolm <dmalcolm@redhat.com> wrote:
> Successfully bootstrapped®rtested on x86_64-pc-linux-gnu.
>
> OK for trunk?
Ok.
Richard.
> gcc/ChangeLog:
> * toplev.c (finalize): Set aux_info_file, asm_out_file, and
> stack_usage_file to NULL after fclose calls.
> ---
> gcc/toplev.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/toplev.c b/gcc/toplev.c
> index b0bb3ec..ddaee8a 100644
> --- a/gcc/toplev.c
> +++ b/gcc/toplev.c
> @@ -1894,6 +1894,7 @@ finalize (bool no_backend)
> if (flag_gen_aux_info)
> {
> fclose (aux_info_file);
> + aux_info_file = NULL;
> if (seen_error ())
> unlink (aux_info_file_name);
> }
> @@ -1908,10 +1909,14 @@ finalize (bool no_backend)
> fatal_error (input_location, "error writing to %s: %m", asm_file_name);
> if (fclose (asm_out_file) != 0)
> fatal_error (input_location, "error closing %s: %m", asm_file_name);
> + asm_out_file = NULL;
> }
>
> if (stack_usage_file)
> - fclose (stack_usage_file);
> + {
> + fclose (stack_usage_file);
> + stack_usage_file = NULL;
> + }
>
> if (!no_backend)
> {
> --
> 1.8.5.3
>
prev parent reply other threads:[~2016-08-10 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 0:56 David Malcolm
2016-08-10 10:15 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc3e4yjCY_5HcZ1tZC8Ujgpi1dVe1Un=U8BOHS8cf4V0=w@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).