[PATCH] toplev.c: set FILE * globals to NULL after fclose

[PATCH] toplev.c: set FILE * globals to NULL after fclose

[David Malcolm]

Successfully bootstrapped&regrtested on x86_64-pc-linux-gnu.

OK for trunk?

gcc/ChangeLog:
	* toplev.c (finalize): Set aux_info_file, asm_out_file, and
	stack_usage_file to NULL after fclose calls.
---
 gcc/toplev.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gcc/toplev.c b/gcc/toplev.c
index b0bb3ec..ddaee8a 100644
--- a/gcc/toplev.c
+++ b/gcc/toplev.c
@@ -1894,6 +1894,7 @@ finalize (bool no_backend)
   if (flag_gen_aux_info)
     {
       fclose (aux_info_file);
+      aux_info_file = NULL;
       if (seen_error ())
 	unlink (aux_info_file_name);
     }
@@ -1908,10 +1909,14 @@ finalize (bool no_backend)
 	fatal_error (input_location, "error writing to %s: %m", asm_file_name);
       if (fclose (asm_out_file) != 0)
 	fatal_error (input_location, "error closing %s: %m", asm_file_name);
+      asm_out_file = NULL;
     }
 
   if (stack_usage_file)
-    fclose (stack_usage_file);
+    {
+      fclose (stack_usage_file);
+      stack_usage_file = NULL;
+    }
 
   if (!no_backend)
     {
-- 
1.8.5.3

Re: [PATCH] toplev.c: set FILE * globals to NULL after fclose

[Richard Biener]

On Wed, Aug 10, 2016 at 3:25 AM, David Malcolm <dmalcolm@redhat.com> wrote:
> Successfully bootstrapped&regrtested on x86_64-pc-linux-gnu.
>
> OK for trunk?

Ok.

Richard.

> gcc/ChangeLog:
>         * toplev.c (finalize): Set aux_info_file, asm_out_file, and
>         stack_usage_file to NULL after fclose calls.
> ---
>  gcc/toplev.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/toplev.c b/gcc/toplev.c
> index b0bb3ec..ddaee8a 100644
> --- a/gcc/toplev.c
> +++ b/gcc/toplev.c
> @@ -1894,6 +1894,7 @@ finalize (bool no_backend)
>    if (flag_gen_aux_info)
>      {
>        fclose (aux_info_file);
> +      aux_info_file = NULL;
>        if (seen_error ())
>         unlink (aux_info_file_name);
>      }
> @@ -1908,10 +1909,14 @@ finalize (bool no_backend)
>         fatal_error (input_location, "error writing to %s: %m", asm_file_name);
>        if (fclose (asm_out_file) != 0)
>         fatal_error (input_location, "error closing %s: %m", asm_file_name);
> +      asm_out_file = NULL;
>      }
>
>    if (stack_usage_file)
> -    fclose (stack_usage_file);
> +    {
> +      fclose (stack_usage_file);
> +      stack_usage_file = NULL;
> +    }
>
>    if (!no_backend)
>      {
> --
> 1.8.5.3
>