From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55278 invoked by alias); 10 Aug 2016 10:15:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 55202 invoked by uid 89); 10 Aug 2016 10:15:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 spammy=U*dmalcolm, sk:dmalcol, dmalcolm@redhat.com, dmalcolmredhatcom X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 10 Aug 2016 10:15:30 +0000 Received: by mail-wm0-f68.google.com with SMTP id i5so8581916wmg.2 for ; Wed, 10 Aug 2016 03:15:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dCcYSbx1M42Mqg+QnWf42ZMXw/uwJe5etNcaLq7VnAs=; b=SYG0ik0mu8zqQ0Y8/jCD1dhtdS6odQ/rySkCBazN5yzCupysKmDtFyjhB5Fj2PRQ9G A4IBez7aMp1E5uFI8+x8rtKbyNl52+1MvYfdcWnQjd6d3irMi3J+ZjLAD6wCjUfMp6bi n3T0tYrqLqvthvhZM6K1P4nmrK8sYDe6sFfu3Taf+1q8895qtIoBhsN/1gBDke6ylIkT Q+etpcUSzeK76ZtZPL77Q7NoIrFH+CqAQ9ZxoiQ+5QRsjzX1Lphn8EwwF/hxv/xsp8fh rNTwjjowl0QIIZ5RNQ5wAolEfa3HSTEvVjUslaeCyeGNZ93VaArBygTdPgS5n0KfRK1z 5mgA== X-Gm-Message-State: AEkoouvAI9Pymb4j3H8iR9B77MSwNxdPgdtNPLe/HckF4m3sOgX9AQOuocmNA4Jxq5m6YYbsBJobKhEI9KwW/A== X-Received: by 10.28.9.194 with SMTP id 185mr2263818wmj.37.1470824127951; Wed, 10 Aug 2016 03:15:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.137.202 with HTTP; Wed, 10 Aug 2016 03:15:27 -0700 (PDT) In-Reply-To: <1470792304-8431-1-git-send-email-dmalcolm@redhat.com> References: <1470792304-8431-1-git-send-email-dmalcolm@redhat.com> From: Richard Biener Date: Wed, 10 Aug 2016 10:15:00 -0000 Message-ID: Subject: Re: [PATCH] toplev.c: set FILE * globals to NULL after fclose To: David Malcolm Cc: GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00794.txt.bz2 On Wed, Aug 10, 2016 at 3:25 AM, David Malcolm wrote: > Successfully bootstrapped®rtested on x86_64-pc-linux-gnu. > > OK for trunk? Ok. Richard. > gcc/ChangeLog: > * toplev.c (finalize): Set aux_info_file, asm_out_file, and > stack_usage_file to NULL after fclose calls. > --- > gcc/toplev.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/gcc/toplev.c b/gcc/toplev.c > index b0bb3ec..ddaee8a 100644 > --- a/gcc/toplev.c > +++ b/gcc/toplev.c > @@ -1894,6 +1894,7 @@ finalize (bool no_backend) > if (flag_gen_aux_info) > { > fclose (aux_info_file); > + aux_info_file = NULL; > if (seen_error ()) > unlink (aux_info_file_name); > } > @@ -1908,10 +1909,14 @@ finalize (bool no_backend) > fatal_error (input_location, "error writing to %s: %m", asm_file_name); > if (fclose (asm_out_file) != 0) > fatal_error (input_location, "error closing %s: %m", asm_file_name); > + asm_out_file = NULL; > } > > if (stack_usage_file) > - fclose (stack_usage_file); > + { > + fclose (stack_usage_file); > + stack_usage_file = NULL; > + } > > if (!no_backend) > { > -- > 1.8.5.3 >