From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3422 invoked by alias); 21 Oct 2014 07:54:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 3412 invoked by uid 89); 21 Oct 2014 07:54:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f169.google.com Received: from mail-wi0-f169.google.com (HELO mail-wi0-f169.google.com) (209.85.212.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 21 Oct 2014 07:54:10 +0000 Received: by mail-wi0-f169.google.com with SMTP id r20so1144259wiv.4 for ; Tue, 21 Oct 2014 00:54:06 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.149.169 with SMTP id ub9mr27118937wib.73.1413878046857; Tue, 21 Oct 2014 00:54:06 -0700 (PDT) Received: by 10.194.20.74 with HTTP; Tue, 21 Oct 2014 00:54:06 -0700 (PDT) In-Reply-To: <544552B7.8070007@redhat.com> References: <544552B7.8070007@redhat.com> Date: Tue, 21 Oct 2014 07:58:00 -0000 Message-ID: Subject: Re: [patch] Second basic-block.h restructuring patch. From: Richard Biener To: Andrew MacLeod Cc: gcc-patches , Jeff Law Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg02009.txt.bz2 On Mon, Oct 20, 2014 at 8:21 PM, Andrew MacLeod wrote: > creates cfg.h, cfganal.h, lcm.h, and loop-unroll.h to house the prototypes > for those .c files. > > cfganal.h also gets "struct edge_list" and "class control_dependences" > definitions since that is where all the routines and manipulators are > declared. > > loop-unroll.h only exports 2 routines, so rather than including that in > basic-block.h I simply included it from the 2 .c files which consume those > routines. Again, the other includes will be flattened out of basic-block.h > to just their consumers later. > > loop-unroll.c also had one function I marked as static since it wasn't > actually used anywhere else. > > bootstraps on x86_64-unknown-linux-gnu, and regressions are running... I > expect no regressions because of the nature of the changes. OK to check in > assuming everything is OK? Ok. Thanks, Richard. > Andrew