From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id BAF913858D29 for ; Fri, 17 Sep 2021 10:03:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BAF913858D29 Received: by mail-ed1-x52e.google.com with SMTP id g8so28006839edt.7 for ; Fri, 17 Sep 2021 03:03:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pI97FpIjxFgHZK4tyTnJkZLxl6pmwp3xPr8Yo0BGZUg=; b=Tz4s5bWd9MQbSGqeqi6+sKs7gBeMkzyg3ew+R6m8lN5r7r0Aeseg7824UWEkI3gONr OnkrXPvU22fMIoSeRsknRnMSZCsMIyQjQCGuRgv14g6G+Pt7AMm9B1wRKxT6uDa1uARL 9JjVsdSWFa8qDrdCqDJA2UoyWA53i1F3XfwztBw8tPkdGqHHig/L6slWycugIJdwR5Qs g/z2YGRsFyI8MQyJc+qhkU66A+Y3phGqnrmlmX1PCsx2PY+pAsBMTgLMu+Jh/NSvhimL Pkrdor/CwdYlnQjd69NezFWTJHS4E2iIUoLqjkou2KzgttF4f9eZdIvkD5CVpSbz+SdC tHBg== X-Gm-Message-State: AOAM5304snYx0A72IjBo4AlfbE3eqXnpSNg5nHQQpIEkwsFhtpFfTko8 HgQQPNXwA6O1VKAuQya6/mWGbnl3BKoVyaMhUR0= X-Google-Smtp-Source: ABdhPJxyp/yI5Ciz8frLM9g7cQkGEXAsLpJAof7hgkpbNd9fMlHYCh2qdf/4EsxmR0itWs/sapYd/MztMO6VcU+jL3I= X-Received: by 2002:a17:907:244a:: with SMTP id yw10mr11071362ejb.571.1631873010754; Fri, 17 Sep 2021 03:03:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Fri, 17 Sep 2021 12:03:19 +0200 Message-ID: Subject: Re: [PATCH] ipa-fnsummary: Remove inconsistent bp_pack_value To: "Kewen.Lin" Cc: GCC Patches , Jan Hubicka , =?UTF-8?Q?Martin_Li=C5=A1ka?= , Martin Jambor , Segher Boessenkool , Bill Schmidt Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Sep 2021 10:03:33 -0000 On Fri, Sep 17, 2021 at 11:43 AM Kewen.Lin wrote: > > Hi, > > When changing target_info with bitfield, I happened to find this > inconsistent streaming in and out. We have the streaming in: > > bp_pack_value (&bp, info->inlinable, 1); > bp_pack_value (&bp, false, 1); > bp_pack_value (&bp, info->fp_expressions, 1); > > while the streaming out: > > info->inlinable = bp_unpack_value (&bp, 1); > info->fp_expressions = bp_unpack_value (&bp, 1) > > The cleanup of Cilk Plus support seemed to miss to remove the bit > streaming out but change with streaming false. > > By hacking fp_expression_p to return true always, I can see it > reads the wrong fp_expressions value (false) out in wpa dumping. > > Bootstrapped and regress-tested on powerpc64le-linux-gnu Power9. > > Is it ok for trunk? OK for trunk and all affected branches (note we need to bump the LTO minor version there). The issue comes from the removal of cilk+ in r8-4956 which removed the bp_unpack but replaced the bp_pack ... It's a correctness issue as we'll read fp_expressions as always 'false' Thanks, Richard. > > BR, > Kewen > ----- > gcc/ChangeLog: > > * ipa-fnsummary.c (ipa_fn_summary_write): Remove inconsistent > bitfield streaming out. > > diff --git a/gcc/ipa-fnsummary.c b/gcc/ipa-fnsummary.c > index 2470937460f..31199919405 100644 > --- a/gcc/ipa-fnsummary.c > +++ b/gcc/ipa-fnsummary.c > @@ -4652,7 +4652,6 @@ ipa_fn_summary_write (void) > info->time.stream_out (ob); > bp = bitpack_create (ob->main_stream); > bp_pack_value (&bp, info->inlinable, 1); > - bp_pack_value (&bp, false, 1); > bp_pack_value (&bp, info->fp_expressions, 1); > streamer_write_bitpack (&bp); > streamer_write_uhwi (ob, vec_safe_length (info->conds));