From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com
 [IPv6:2607:f8b0:4864:20::92b])
 by sourceware.org (Postfix) with ESMTPS id 9505A3836030
 for <gcc-patches@gcc.gnu.org>; Mon,  9 May 2022 12:03:46 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9505A3836030
Received: by mail-ua1-x92b.google.com with SMTP id x5so5361539uap.8
 for <gcc-patches@gcc.gnu.org>; Mon, 09 May 2022 05:03:46 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=V+qQO6Ddt7kRhW8MipVYR6OIWzgA3rwppd/q2Vm1j8E=;
 b=P94Z5yXQELXuvYdpnaaqvitVMo1mO2d5MRQ3ZeNzuuVKNKZrxVWuj8MGRwagZzDuqX
 UT8oAGm8/Rn5KAn4NhV08RbytUsOMN93ybs/SaPYcLiVOCN9GoVpZAkmlq6D6qWJG3yw
 cbzdDPj7Swv+peTwPWbH0bc4XGEb8JzAaY7uxtAgzc4fAAmPcGi2d6WBZUoqRkzajrx8
 bUsfmNxsafZNN6430kQh8liktli+w72TQBUGQX2CKzgdSstsjFk9fGyYKQUG4Etxsz6g
 UGB25ECzD/KhAynPHT8vmxpZxQkm7NR8JfKhaccrA6YmCyzeP1aZQwfMZ+jP+5mmI/tK
 MrWA==
X-Gm-Message-State: AOAM530AuSqWD2yQKdsfLvIc7nQBaFOs/Fxn5AvIOx8ae9EZQYtB3Lv1
 2YqtK81MIEeiHS9gqGcuEo02cesJtazoyZfLpis=
X-Google-Smtp-Source: ABdhPJxaBjjOU2Y+V/ED/oBLSOwuwpTz+jUobcJ7P0PRiLV8fDKSMC53BbynpgUWE99D6h0T78IyLfdkV5VTOsgaqYc=
X-Received: by 2002:ab0:30ce:0:b0:362:7eb0:62b8 with SMTP id
 c14-20020ab030ce000000b003627eb062b8mr7588217uam.94.1652097825998; Mon, 09
 May 2022 05:03:45 -0700 (PDT)
MIME-Version: 1.0
References: <b22b8d81-4340-b107-1949-916b7436c77e@suse.cz>
 <1651754853.85hnr42bjs.astroid@pulse.none>
 <934763f4-4d77-dd93-5d6e-1107380c5b06@suse.cz>
In-Reply-To: <934763f4-4d77-dd93-5d6e-1107380c5b06@suse.cz>
From: Richard Biener <richard.guenther@gmail.com>
Date: Mon, 9 May 2022 14:03:34 +0200
Message-ID: <CAFiYyc3iBV12CsJ4VHFKTyf36CfxMvEu_OrY1CpvQhsFcmE3cw@mail.gmail.com>
Subject: Re: [PATCH] Use more ARRAY_SIZE.
To: =?UTF-8?Q?Martin_Li=C5=A1ka?= <mliska@suse.cz>
Cc: Iain Buclaw <ibuclaw@gdcproject.org>, GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 09 May 2022 12:03:48 -0000

On Thu, May 5, 2022 at 4:30 PM Martin Li=C5=A1ka <mliska@suse.cz> wrote:
>
> On 5/5/22 14:58, Iain Buclaw wrote:
> > This D front-end change doesn't look right to me, besides the slight
>
> Hello.
>
> Sorry, I've re-read the patch and fixed some places where the macro usage
> was wrong.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

The middle-end parts are OK.  I'd say in files where ARRAY_SIZE is already
used it's OK to introduce more uses.  Otherwise I defer to the more specifi=
c
maintainers if they like this or not.

Richard.

> Martin