From: Richard Biener <richard.guenther@gmail.com>
To: Bin Cheng <Bin.Cheng@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>
Subject: Re: [PATCH GCC][1/2]Feed bound computation to folder in loop split
Date: Fri, 16 Jun 2017 10:49:00 -0000 [thread overview]
Message-ID: <CAFiYyc3jsS0EkbOFR45LWb2B5XoCsPFacfQNHE2r3yF+mAe6gg@mail.gmail.com> (raw)
In-Reply-To: <VI1PR0802MB2176DBE6A7DBF9A434104979E7C30@VI1PR0802MB2176.eurprd08.prod.outlook.com>
On Wed, Jun 14, 2017 at 3:07 PM, Bin Cheng <Bin.Cheng@arm.com> wrote:
> Hi,
> Loop split forces intermediate computation to gimple operands all the time when
> computing bound information. This is not good since folding opportunities are
> missed. This patch fixes the issue by feeding all computation to folder and only
> forcing to gimple operand at last.
>
> Bootstrap and test on x86_64 and AArch64. Is it OK?
Hm? It uses gimple_build () which should do the same as fold_buildN in terms
of simplification.
So where does that not work? It is supposed to be the prefered way and no
new code should use force_gimple_operand (unless dealing with generic
coming from other middle-end infrastructure like SCEV or niter analysis)
Richard.
>
> Thanks,
> bin
> 2017-06-12 Bin Cheng <bin.cheng@arm.com>
>
> * tree-ssa-loop-split.c (compute_new_first_bound): Feed bound
> computation to folder, rather than force to gimple operands too
> early.
next prev parent reply other threads:[~2017-06-16 10:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 13:07 Bin Cheng
2017-06-16 10:49 ` Richard Biener [this message]
2017-06-16 13:06 ` Bin.Cheng
2017-06-16 13:10 ` Richard Biener
2017-06-16 13:31 ` Bin.Cheng
2017-06-16 16:16 ` Richard Biener
2017-06-16 16:23 ` Bin.Cheng
2017-06-16 16:48 ` Marc Glisse
2017-06-16 16:58 ` Bin.Cheng
2017-06-16 17:04 ` Andrew Pinski
2017-07-24 11:45 ` Bin.Cheng
2017-07-24 12:16 ` Marc Glisse
2017-07-24 13:49 ` Bin.Cheng
2017-07-24 13:59 ` Marc Glisse
2017-07-24 14:06 ` Bin.Cheng
2017-07-24 14:31 ` Marc Glisse
2017-07-24 14:37 ` Bin.Cheng
2017-07-24 14:52 ` Marc Glisse
2017-07-25 14:32 ` Richard Biener
2017-07-25 17:45 ` Marc Glisse
2017-07-26 7:48 ` Richard Biener
2017-07-26 9:08 ` Richard Sandiford
2017-07-26 9:38 ` Marc Glisse
2017-07-26 9:45 ` Richard Sandiford
2017-07-26 9:57 ` Marc Glisse
2017-07-26 11:13 ` Richard Biener
2017-07-26 11:46 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc3jsS0EkbOFR45LWb2B5XoCsPFacfQNHE2r3yF+mAe6gg@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=Bin.Cheng@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).