From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70615 invoked by alias); 21 Jun 2019 14:28:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 70599 invoked by uid 89); 21 Jun 2019 14:28:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-lj1-f195.google.com Received: from mail-lj1-f195.google.com (HELO mail-lj1-f195.google.com) (209.85.208.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Jun 2019 14:28:26 +0000 Received: by mail-lj1-f195.google.com with SMTP id 16so6122088ljv.10; Fri, 21 Jun 2019 07:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AQk5T4+8LOgrsix5QZdRt8W3QfAa3QK6qS+ZqV4voYw=; b=Yt07ZYAoQq6wMgikd9EIeifWGZqveo5O5rV7cIlgqyJVdiPbL3ZkL79Li5hAMmoH/i Lv3FA62Y7WtM840siRtnmM500vQAKfaNrQ2hBJUIHyDa3PAH0LvNhHxaOcSYmY+BTET0 7uzoJpnt2o/C7H4sOoRRGhLyFl7duWwx9yKjyHVkoeaBFG4ykG8LPICzFb/4GSqVttGd XD7DZgfJwLF3p6quy9Yzo3n2kJnw5fbUWd5H6RPHY7DS+HmYv3sfw0OwIgG4/Zfi31Hs 6o4gTivFmEndJCB7x/Ba5uLsvxuLXxo1ZzV3479TNqMjVFBt4sNS205Peckfg5fEgJ1K fdig== MIME-Version: 1.0 References: <884b9feb-3e71-db00-8c72-8e096bf75c1e@suse.cz> <69a11998-93c1-d61d-ba31-ac93bcbb353a@suse.cz> <20190621115838.GX815@tucnak> <79fcb5a4-0eba-d39f-e7ca-389f371cd48c@suse.cz> <20190621141309.GY815@tucnak> In-Reply-To: <20190621141309.GY815@tucnak> From: Richard Biener Date: Fri, 21 Jun 2019 14:28:00 -0000 Message-ID: Subject: Re: [PATCH] Deprecate -frepo option. To: Jakub Jelinek Cc: =?UTF-8?Q?Martin_Li=C5=A1ka?= , Jonathan Wakely , Iain Sandoe , "gcc@gcc.gnu.org" , David Edelsohn , Jan Hubicka , GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg01318.txt.bz2 On Fri, Jun 21, 2019 at 4:13 PM Jakub Jelinek wrote: > > On Fri, Jun 21, 2019 at 04:04:00PM +0200, Martin Li=C5=A1ka wrote: > > On 6/21/19 1:58 PM, Jakub Jelinek wrote: > > > On Fri, Jun 21, 2019 at 01:52:09PM +0200, Martin Li=C5=A1ka wrote: > > >> On 6/21/19 1:47 PM, Jonathan Wakely wrote: > > >>> On Fri, 21 Jun 2019 at 11:40, Martin Li=C5=A1ka wrote: > > >>>> Yes, I would be fine to deprecate that for GCC 10.1 > > >>> > > >>> Would it be appropriate to issue a warning in GCC 10.x if the optio= n is used? > > >> > > >> Sure. With the patch attached one will see: > > >> > > >> $ gcc -frepo /tmp/main.cc -c > > >> gcc: warning: switch =E2=80=98-frepo=E2=80=99 is no longer supported > > >> > > >> I'm sending patch that also removes -frepo tests from test-suite. > > >> I've been testing the patch. > > > > > > IMHO for just deprecation of an option you don't want to remove it fr= om the > > > testsuite, just match the warning it will generate in those tests, and > > > I'm not convinced you want to remove it from the documentation (rathe= r than > > > just saying in the documentation that the option is deprecated and mi= ght be > > > removed in a later GCC version). > > > > Agree with you. I'm sending updated version of the patch. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > I'm also not convinced about the Deprecated flag, seems like that is a fl= ag > that we use for options that have been already removed. > So, instead there should be some proper warning in the C++ FE for it, > or just Warn. In principle -frepo is a nice idea - does it live up to its promises? That= is, does it actually work, for example when throwing it on the libstdc++ testsuite or a larger C++ project? The option doesn't document optimization issues but I assume template bodies are not available for IPA optimizations unless -frepo is combined with LTO where the template CU[s] then bring them in. So I'm not sure - do we really want to remove this feature? Richard. > Jakub