Re: [RFC, middlend] Fix for PR54218

[Richard Biener <richard.guenther@gmail.com>]

On Fri, Jan 11, 2013 at 6:37 PM, George Thomas
<georgethomas.mec@gmail.com> wrote:
> On Fri, Jan 11, 2013 at 9:53 PM, Andrew Pinski <pinskia@gmail.com> wrote:
>> On Fri, Jan 11, 2013 at 8:17 AM, George Thomas
>> <georgethomas.mec@gmail.com> wrote:
>>> Hi,
>>>
>>> I am sending a patch which solves the debugging issue (PR 54218).
>>>
>>> The fix is to allocate stack space only once for parameters in expand pass.
>>>
>>> The patch is attached. Could someone suggest if its right ?
>>
>> I have just a formatting issue:
>> +         if (TREE_CODE (SSA_NAME_VAR (var)) != PARM_DECL)
>> +          {
>> +            if (!bitmap_bit_p (SA.partition_has_default_def, i))
>>
>> I think it would have been better if you had done instead:
>>           if (TREE_CODE (SSA_NAME_VAR (var)) != PARM_DECL
>>              && !bitmap_bit_p (SA.partition_has_default_def, i))
>>
>
> I have attached the updated patch with the changes suggested.
> Also adding a dejagnu test case to reproduce the bug.
>
>> So there are no other white space changes.
>>
>> Also missing a changelog entry too.
>>
>
> I am adding the change logs below.
>
> 2013-01-11  George Thomas  <george.thomas@atmel.com>
>                      Senthil Kumar Selvaraj <Senthil_Kumar.Selvaraj@atmel.com>
>
>          PR middle-end/54218
>
>          * gcc/cfgexpand.c (expand_used_vars ) :Added
>                   a step to not allocate stack space if its a parameter
>
>          * gcc.dg/pr54218.c : New test
>
>
> Hoping that the changes are fine for trunk.

Please state how you tested the patch (bootstrap and regtest on which target?)

Thanks,
Richard.

>
> Thanks,
> George