[GSoC][match-and-simplify] add more constant folding tests

[GSoC][match-and-simplify] add more constant folding tests

[Prathamesh Kulkarni]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

We now have at-least one test-case for each of constant folding patterns
in match-constant-folding.pd

[gcc/testsuite/gcc.dg/tree-ssa]
  * match-constant-folding.c: Add test-cases.

Thanks,
Prathamesh

[-- Attachment #2: constant-folding-tests.patch --]
[-- Type: text/x-patch, Size: 1849 bytes --]

Index: match-constant-folding.c
===================================================================
--- match-constant-folding.c	(revision 214020)
+++ match-constant-folding.c	(working copy)
@@ -55,4 +55,68 @@ int c6(int x)
 }
 /* { dg-final { scan-tree-dump "Match-and-simplified x_\\d\+\\(D\\) \\* t1_\\d\+ to x_\\d\+\\(D\\)" "ccp1" } } */
 
+/* x / 1 -> x */
+int c7(int x)
+{
+  int t1 = 1;
+  int c7_val = x / t1;
+  return c7_val;
+}
+/* { dg-final { scan-tree-dump "Match-and-simplified x_\\d\+\\(D\\) / t1_\\d\+ to x_\\d\+\\(D\\)" "ccp1" } } */
+
+/* x % x -> 1 */
+int c8(int x)
+{
+  int t1 = x;
+  int c8_val = x % t1;
+  return c8_val;
+}
+/* { dg-final { scan-tree-dump "gimple_simplified to c8_val_\\d\+ = 0" "forwprop1" } } */
+
+/* x | 0 -> x */
+int c9(int x)
+{
+  int t1 = 0;
+  int c9_val = x | t1;
+  return c9_val;
+}
+/* { dg-final { scan-tree-dump "Match-and-simplified x_\\d\+\\(D\\) | t1_\\d\+ to x_\\d\+\\(D\\)" "ccp1" } } */
+
+/* x | -1 -> -1 */
+int c10(int x)
+{
+  int t1 = -1;
+  int c10_val = x | t1;
+  return c10_val;
+}
+/* { dg-final { scan-tree-dump "Match-and-simplified x_\\d\+\\(D\\) | t1_\\d\+ to -1" "ccp1" } } */
+
+/* x & -1 -> x */
+int c11(int x)
+{
+  int t1 = -1;
+  int c11_val = x & t1;
+  return c11_val;
+}
+/* { dg-final { scan-tree-dump "Match-and-simplified x_\\d\+\\(D\\) & t1_\\d\+ to x_\\d\+\\(D\\)" "ccp1" } } */
+
+/* x & 0 -> 0 */
+int c12(int x)
+{
+  int t1 = 0;
+  int c12_val = x & t1;
+  return c12_val;
+}
+/* { dg-final { scan-tree-dump "Match-and-simplified x_\\d\+\\(D\\) & t1_\\d\+ to 0" "ccp1" } } */
+
+/* x ^ 0 -> x */
+int c13(int x)
+{
+  int t1 = 0;
+  int c13_val = x ^ t1;
+  return c13_val;
+}
+/* { dg-final { scan-tree-dump "Match-and-simplified x_\\d\+\\(D\\) \\^ t1_\\d\+ to x_\\d\+\\(D\\)" "ccp1" } } */
+
+
 /* { dg-final { cleanup-tree-dump "forwprop2" } } */

Re: [GSoC][match-and-simplify] add more constant folding tests

[Richard Biener]

On Sun, Aug 17, 2014 at 9:41 PM, Prathamesh Kulkarni
<bilbotheelffriend@gmail.com> wrote:
> We now have at-least one test-case for each of constant folding patterns
> in match-constant-folding.pd
>
> [gcc/testsuite/gcc.dg/tree-ssa]
>   * match-constant-folding.c: Add test-cases.

Thanks - committed.

Richard.

> Thanks,
> Prathamesh

Re: [GSoC][match-and-simplify] add more constant folding tests

[David Malcolm]

On Mon, 2014-08-18 at 01:11 +0530, Prathamesh Kulkarni wrote:
> We now have at-least one test-case for each of constant folding
> patterns
> in match-constant-folding.pd
> 
> [gcc/testsuite/gcc.dg/tree-ssa]
>   * match-constant-folding.c: Add test-cases.
> 
> [...snip...]

A minor nit for one of the comments, for modulo division:

> Index: match-constant-folding.c
> ===================================================================
> --- match-constant-folding.c    (revision 214020)
> +++ match-constant-folding.c    (working copy)
[...]

> +/* x % x -> 1 */
               ^
0, rather than 1, surely?

Re: [GSoC][match-and-simplify] add more constant folding tests

[Prathamesh Kulkarni]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On Mon, Aug 18, 2014 at 11:06 PM, David Malcolm <dmalcolm@redhat.com> wrote:
> On Mon, 2014-08-18 at 01:11 +0530, Prathamesh Kulkarni wrote:
>> We now have at-least one test-case for each of constant folding
>> patterns
>> in match-constant-folding.pd
>>
>> [gcc/testsuite/gcc.dg/tree-ssa]
>>   * match-constant-folding.c: Add test-cases.
>>
>> [...snip...]
>
> A minor nit for one of the comments, for modulo division:
>
>> Index: match-constant-folding.c
>> ===================================================================
>> --- match-constant-folding.c    (revision 214020)
>> +++ match-constant-folding.c    (working copy)
> [...]
>
>> +/* x % x -> 1 */
>                ^
> 0, rather than 1, surely?
Thanks, fixed in this patch.

* testsuite/match-constant-folding.c: Fix typo.

Regards,
Prathamesh
>
>
>

[-- Attachment #2: foo.patch --]
[-- Type: text/x-patch, Size: 410 bytes --]

Index: match-constant-folding.c
===================================================================
--- match-constant-folding.c	(revision 214101)
+++ match-constant-folding.c	(working copy)
@@ -64,7 +64,7 @@ int c7(int x)
 }
 /* { dg-final { scan-tree-dump "Match-and-simplified x_\\d\+\\(D\\) / t1_\\d\+ to x_\\d\+\\(D\\)" "ccp1" } } */
 
-/* x % x -> 1 */
+/* x % x -> 0 */
 int c8(int x)
 {
   int t1 = x;

Re: [GSoC][match-and-simplify] add more constant folding tests

[Richard Biener]

On Mon, Aug 18, 2014 at 8:00 PM, Prathamesh Kulkarni
<bilbotheelffriend@gmail.com> wrote:
> On Mon, Aug 18, 2014 at 11:06 PM, David Malcolm <dmalcolm@redhat.com> wrote:
>> On Mon, 2014-08-18 at 01:11 +0530, Prathamesh Kulkarni wrote:
>>> We now have at-least one test-case for each of constant folding
>>> patterns
>>> in match-constant-folding.pd
>>>
>>> [gcc/testsuite/gcc.dg/tree-ssa]
>>>   * match-constant-folding.c: Add test-cases.
>>>
>>> [...snip...]
>>
>> A minor nit for one of the comments, for modulo division:
>>
>>> Index: match-constant-folding.c
>>> ===================================================================
>>> --- match-constant-folding.c    (revision 214020)
>>> +++ match-constant-folding.c    (working copy)
>> [...]
>>
>>> +/* x % x -> 1 */
>>                ^
>> 0, rather than 1, surely?
> Thanks, fixed in this patch.
>
> * testsuite/match-constant-folding.c: Fix typo.

Applied.

Richard.

> Regards,
> Prathamesh
>>
>>
>>