public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@caviumnetworks.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PR25529] Convert (unsigned t * 2)/2 into unsigned (t & 0x7FFFFFFF)
Date: Tue, 11 Aug 2015 12:51:00 -0000	[thread overview]
Message-ID: <CAFiYyc3qC2Jem4ocEjHmqodRdhs5JLT8W5DskCfOdjnXtMhkbw@mail.gmail.com> (raw)
In-Reply-To: <CAFiYyc19s1KO4pjUPeZ+wvhGCYd-Ar=iTMyZkGHJKcNFOdx7=w@mail.gmail.com>

On Tue, Aug 11, 2015 at 2:50 PM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Fri, Aug 7, 2015 at 10:43 AM, Hurugalawadi, Naveen
> <Naveen.Hurugalawadi@caviumnetworks.com> wrote:
>> Hi,
>>
>>>> extend it - it should also work for non-INTEGER_CST
>>>> divisors and it should work for any kind of division, not just exact_div.
>>
>> Please find attached the patch "pr25529.patch" that implements the pattern
>> for all divisors
>>
>> Please review and let me know if its okay.
>
> Ok.

Err, sorry.  You are missing a

 ANY_INTEGRAL_TYPE_P (type)

before the TYPE_OVERFLOW_UNDEFINED check which should simply
operate on 'type' rather than TREE_TYPE (@0).

Ok with that changes.

Richard.

> Thanks,
> Richard.
>
>> Regression tested on AARH64 and x86_64.
>>
>> Thanks,
>> Naveen
>>
>> 2015-08-07  Naveen H.S  <Naveen.Hurugalawadi@caviumnetworks.com>
>>
>> PR middle-end/25529
>>
>>         gcc/ChangeLog:
>>         * match.pd (div (mult @0 @1) @1) : New simplifier.
>>

  reply	other threads:[~2015-08-11 12:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07  4:52 Hurugalawadi, Naveen
2015-07-07  6:06 ` Marc Glisse
2015-07-07  9:12   ` Richard Biener
2015-07-07  9:24     ` Marc Glisse
2015-07-07  9:35       ` Richard Biener
2015-07-21  9:16         ` Hurugalawadi, Naveen
2015-07-22 12:10           ` Richard Biener
2015-07-23  3:59             ` Hurugalawadi, Naveen
2015-07-23 13:36               ` Richard Biener
2015-08-07  8:44                 ` Hurugalawadi, Naveen
2015-08-11 12:50                   ` Richard Biener
2015-08-11 12:51                     ` Richard Biener [this message]
2015-08-20 20:10                   ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFiYyc3qC2Jem4ocEjHmqodRdhs5JLT8W5DskCfOdjnXtMhkbw@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=Naveen.Hurugalawadi@caviumnetworks.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).