From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-404978-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 27262 invoked by alias); 11 Aug 2015 12:51:32 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 27251 invoked by uid 89); 11 Aug 2015 12:51:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-io0-f174.google.com
Received: from mail-io0-f174.google.com (HELO mail-io0-f174.google.com) (209.85.223.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 11 Aug 2015 12:51:31 +0000
Received: by iods203 with SMTP id s203so3657543iod.0        for <gcc-patches@gcc.gnu.org>; Tue, 11 Aug 2015 05:51:29 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.107.137.87 with SMTP id l84mr32510116iod.119.1439297489435; Tue, 11 Aug 2015 05:51:29 -0700 (PDT)
Received: by 10.107.32.140 with HTTP; Tue, 11 Aug 2015 05:51:29 -0700 (PDT)
In-Reply-To: <CAFiYyc19s1KO4pjUPeZ+wvhGCYd-Ar=iTMyZkGHJKcNFOdx7=w@mail.gmail.com>
References: <SN2PR0701MB1024267AF107C82E4F2F8A6C8E920@SN2PR0701MB1024.namprd07.prod.outlook.com>	<alpine.DEB.2.20.1507070800550.1693@laptop-mg.saclay.inria.fr>	<CAFiYyc1c_NVr1eKVg3v5xv4829aMDbp0QnrmeB-BEYCmg6uQ+A@mail.gmail.com>	<alpine.DEB.2.20.1507071121510.1875@laptop-mg.saclay.inria.fr>	<CAFiYyc07MCwT9NF_OQTE92KG0Rf+3Oex_muSRTx7Ji9TF99Jag@mail.gmail.com>	<DM2PR0701MB1018959170F8B70E4C982C628E840@DM2PR0701MB1018.namprd07.prod.outlook.com>	<CAFiYyc2=EyQvrDK+4PfUMQwHLY1EK0ZDg5WoY+ZXQ8k5oP_7NQ@mail.gmail.com>	<SN2PR0701MB1024E2FD81BA317E4CFFE98F8E820@SN2PR0701MB1024.namprd07.prod.outlook.com>	<CAFiYyc0t3O6fuRsST=PHVBM5+cG1ata+2r=B2b47WN=pMjyfqg@mail.gmail.com>	<SN2PR0701MB1024C09A0E0C1C2885ABBEE68E730@SN2PR0701MB1024.namprd07.prod.outlook.com>	<CAFiYyc19s1KO4pjUPeZ+wvhGCYd-Ar=iTMyZkGHJKcNFOdx7=w@mail.gmail.com>
Date: Tue, 11 Aug 2015 12:51:00 -0000
Message-ID: <CAFiYyc3qC2Jem4ocEjHmqodRdhs5JLT8W5DskCfOdjnXtMhkbw@mail.gmail.com>
Subject: Re: [PR25529] Convert (unsigned t * 2)/2 into unsigned (t & 0x7FFFFFFF)
From: Richard Biener <richard.guenther@gmail.com>
To: "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@caviumnetworks.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-08/txt/msg00515.txt.bz2

On Tue, Aug 11, 2015 at 2:50 PM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Fri, Aug 7, 2015 at 10:43 AM, Hurugalawadi, Naveen
> <Naveen.Hurugalawadi@caviumnetworks.com> wrote:
>> Hi,
>>
>>>> extend it - it should also work for non-INTEGER_CST
>>>> divisors and it should work for any kind of division, not just exact_div.
>>
>> Please find attached the patch "pr25529.patch" that implements the pattern
>> for all divisors
>>
>> Please review and let me know if its okay.
>
> Ok.

Err, sorry.  You are missing a

 ANY_INTEGRAL_TYPE_P (type)

before the TYPE_OVERFLOW_UNDEFINED check which should simply
operate on 'type' rather than TREE_TYPE (@0).

Ok with that changes.

Richard.

> Thanks,
> Richard.
>
>> Regression tested on AARH64 and x86_64.
>>
>> Thanks,
>> Naveen
>>
>> 2015-08-07  Naveen H.S  <Naveen.Hurugalawadi@caviumnetworks.com>
>>
>> PR middle-end/25529
>>
>>         gcc/ChangeLog:
>>         * match.pd (div (mult @0 @1) @1) : New simplifier.
>>