From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60196 invoked by alias); 5 Mar 2015 08:47:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60185 invoked by uid 89); 5 Mar 2015 08:47:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-oi0-f43.google.com Received: from mail-oi0-f43.google.com (HELO mail-oi0-f43.google.com) (209.85.218.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 05 Mar 2015 08:47:36 +0000 Received: by oiav63 with SMTP id v63so10532050oia.13 for ; Thu, 05 Mar 2015 00:47:34 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.202.204.88 with SMTP id c85mr5758531oig.81.1425545254239; Thu, 05 Mar 2015 00:47:34 -0800 (PST) Received: by 10.76.98.137 with HTTP; Thu, 5 Mar 2015 00:47:34 -0800 (PST) In-Reply-To: <20150305005444.GD86051@kam.mff.cuni.cz> References: <54F3F648.8090400@redhat.com> <54F697A5.6090908@redhat.com> <20150305005444.GD86051@kam.mff.cuni.cz> Date: Thu, 05 Mar 2015 08:47:00 -0000 Message-ID: Subject: Re: [patch/committed] PR middle-end/65233 make walk-ssa_copies handle empty PHIs From: Richard Biener To: Jan Hubicka Cc: Jeff Law , Aldy Hernandez , gcc-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00266.txt.bz2 On Thu, Mar 5, 2015 at 1:54 AM, Jan Hubicka wrote: >> > >> > It gets passed the valueize callback now which returns NULL_TREE for >> > SSA names we can't follow. >> >> Btw, for match-and-simplify I had to use that as default for fold_stmt >> _exactly_ because of the call to fold_stmt from replace_uses_by >> via merge-blocks from cfgcleanup. This is because replace-uses-by >> doesn't have all uses replaced before it folds the stmt! >> >> We also have the "weaker" in-place flag. >> >> 2015-03-04 Richard Biener >> >> PR middle-end/65233 >> * ipa-polymorphic-call.c: Include tree-ssa-operands.h and >> tree-into-ssa.h. >> (walk_ssa_copies): Revert last chage. Instead do not walk >> SSA names registered for SSA update. > > Maybe include the patch? It should not be problem to make the function > to valuelize everything it looks into. I attached it. Well, I think for stage1 the fix is to not call fold_stmt from CFG hooks or CFG cleanup. Merge-blocks can just demote PHIs to assignments and leave propagation to followup cleanups (we can of course propagate virtual operands). I can try to do it for this stage (I can only find merge-blocks doing this) as well. Opinions? Richard. > Honza