From: Richard Biener <richard.guenther@gmail.com>
To: Eric Botcazou <botcazou@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] Fix ICE with stack checking emulation at -O2
Date: Fri, 1 Oct 2021 10:23:15 +0200 [thread overview]
Message-ID: <CAFiYyc3t7yCnSFFX995C2PeTPd5dBf55Nqbpc9t-_yfkWSLQpA@mail.gmail.com> (raw)
In-Reply-To: <4346425.LvFx2qVVIh@fomalhaut>
On Fri, Oct 1, 2021 at 10:17 AM Eric Botcazou via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi,
>
> this is a regression present on mainline, 11 and 10 branches: on bare-metal
> platforms, the Ada compiler emulates stack checking (it is required by the
> language and tested by ACATS) in the runtime via the stack_check_libfunc hook
> of the RTL middle-end. Calls to the function are generated as libcalls but
> they now require a proper function type at -O2 or above.
>
> Tested on powerpc-elf, OK for mainline, 11 and 10 branches?
OK though I wonder if you could get away with using
built_function_type (void_type_node, NULL_TREE); aka
a non-prototype void f().
Did you track down what changed the requirement?
Thanks,
Richard.
>
> 2021-10-01 Eric Botcazou <ebotcazou@adacore.com>
>
> * explow.c: Include langhooks.h.
> (set_stack_check_libfunc): Build a proper function type.
>
> --
> Eric Botcazou
next prev parent reply other threads:[~2021-10-01 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 8:16 Eric Botcazou
2021-10-01 8:23 ` Richard Biener [this message]
2021-10-01 8:30 ` Eric Botcazou
2021-10-01 8:43 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc3t7yCnSFFX995C2PeTPd5dBf55Nqbpc9t-_yfkWSLQpA@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).