From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com
 [IPv6:2a00:1450:4864:20::536])
 by sourceware.org (Postfix) with ESMTPS id 2D9433858C2C
 for <gcc-patches@gcc.gnu.org>; Fri,  1 Oct 2021 08:23:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2D9433858C2C
Received: by mail-ed1-x536.google.com with SMTP id l8so32147059edw.2
 for <gcc-patches@gcc.gnu.org>; Fri, 01 Oct 2021 01:23:28 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=pqelfm2+5ptOdHIvUmOKoiy064WYj9Ezf9czUWEMkE4=;
 b=eyfV6JDotPoI07XsHJMhzCwxXwNKu00+PjGJVzvEsKINea2ud0k7x4i+pWMDDy3RZB
 OjbqxNg83Lc5Aqw82LIjHqOJKPWp4Ef28EqlVM7feLCzKPcUw4f5zH7c3npb1oe5FwMW
 DpnJ4pWwm+ELAEOeHjxdXdclYvYstt2gyIJgZLQX5ExaXUER2cALSJ4gQA89Y+J17Evr
 ua9ToYbZ4V7JBx8oZVJb+4oMEXxxGySWeYJHtRKA+QZkI/B9v6pB5jz9VXYc0jJE396q
 pcqcuNOXvpGStFkPQLfICTkNeE04T2lXPINrkJJlduquM/PYKL8bxnkcBUHAroT8QxtL
 i8AA==
X-Gm-Message-State: AOAM531mP0jG+R6sl6vHGKEhO+7uBVRTNWp5QCl2ROqmcanG2nxNYJd2
 kf/HKqAE/XKJVdtXUhWGhuAlP9zDv13pla/TMgE=
X-Google-Smtp-Source: ABdhPJxCOvSs4+w/TkuRk0sw4+GhFKWsji9nKMoQilVjgpumTNKvDdynORgCrPoMaMl1b8UnEazokEP8VrPk4itXtjo=
X-Received: by 2002:a17:906:d207:: with SMTP id
 w7mr4467511ejz.571.1633076606756; 
 Fri, 01 Oct 2021 01:23:26 -0700 (PDT)
MIME-Version: 1.0
References: <4346425.LvFx2qVVIh@fomalhaut>
In-Reply-To: <4346425.LvFx2qVVIh@fomalhaut>
From: Richard Biener <richard.guenther@gmail.com>
Date: Fri, 1 Oct 2021 10:23:15 +0200
Message-ID: <CAFiYyc3t7yCnSFFX995C2PeTPd5dBf55Nqbpc9t-_yfkWSLQpA@mail.gmail.com>
Subject: Re: [patch] Fix ICE with stack checking emulation at -O2
To: Eric Botcazou <botcazou@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Oct 2021 08:23:29 -0000

On Fri, Oct 1, 2021 at 10:17 AM Eric Botcazou via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi,
>
> this is a regression present on mainline, 11 and 10 branches: on bare-metal
> platforms, the Ada compiler emulates stack checking (it is required by the
> language and tested by ACATS) in the runtime via the stack_check_libfunc hook
> of the RTL middle-end.  Calls to the function are generated as libcalls but
> they now require a proper function type at -O2 or above.
>
> Tested on powerpc-elf, OK for mainline, 11 and 10 branches?

OK though I wonder if you could get away with using
built_function_type (void_type_node, NULL_TREE); aka
a non-prototype void f().

Did you track down what changed the requirement?

Thanks,
Richard.

>
> 2021-10-01  Eric Botcazou  <ebotcazou@adacore.com>
>
>         * explow.c: Include langhooks.h.
>         (set_stack_check_libfunc): Build a proper function type.
>
> --
> Eric Botcazou