public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: will_schmidt@vnet.ibm.com
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Externalize definition of create_tmp_reg_or_ssa_name
Date: Tue, 20 Dec 2016 10:48:00 -0000	[thread overview]
Message-ID: <CAFiYyc3xxrqoKmWfG4cT38iYkRCfwosaG=CC28KU+8EUwwvdvg@mail.gmail.com> (raw)
In-Reply-To: <1482168435.13393.76.camel@brimstone.rchland.ibm.com>

On Mon, Dec 19, 2016 at 6:27 PM, Will Schmidt <will_schmidt@vnet.ibm.com> wrote:
> Hi,
>
> For some future rs6000 vector folding patches, I will be needing
> access to the create_tmp_reg_or_ssa_name() function in rs6000.c.
> Thus...
> Externalize the definition of create_tmp_reg_or_ssa_name
> for use in rs6000.c.  The actual usage will show up in later patches.
>
> I'll note that I do not have any 'usage' patches quite ready to go, so
> I may just sit on committing this until one of those usage patches is ready.
>
> I've bootstrapped and make check with this patch applied in conjunction with
> other patches.
>
> OK for trunk?

Ok.

Richard.

>
> [gcc]
>
> 2016-12-19  Will Schmidt  <will_schmidt@vnet.ibm.com>
>
>         *  gimple-fold.c (create_tmp_reg_or_ssa_name): remove static declaration.
>         *  gimple-fold.h: add prototype.
>
> diff --git a/gcc/gimple-fold.c b/gcc/gimple-fold.c
> index d00625b..ac4498f 100644
> --- a/gcc/gimple-fold.c
> +++ b/gcc/gimple-fold.c
> @@ -161,8 +161,8 @@ can_refer_decl_in_current_unit_p (tree decl, tree from_decl)
>     is in SSA form, a SSA name is created.  Otherwise a temporary register
>     is made.  */
>
> -static tree
> -create_tmp_reg_or_ssa_name (tree type, gimple *stmt = NULL)
> +tree
> +create_tmp_reg_or_ssa_name (tree type, gimple *stmt)
>  {
>    if (gimple_in_ssa_p (cfun))
>      return make_ssa_name (type, stmt);
> diff --git a/gcc/gimple-fold.h b/gcc/gimple-fold.h
> index 5add30c..e7f8fe2 100644
> --- a/gcc/gimple-fold.h
> +++ b/gcc/gimple-fold.h
> @@ -22,6 +22,7 @@ along with GCC; see the file COPYING3.  If not see
>  #ifndef GCC_GIMPLE_FOLD_H
>  #define GCC_GIMPLE_FOLD_H
>
> +extern tree create_tmp_reg_or_ssa_name (tree, gimple *stmt = NULL);
>  extern tree canonicalize_constructor_val (tree, tree);
>  extern tree get_symbol_constant_value (tree);
>  extern void get_range_strlen (tree, tree[2]);
>
>

  reply	other threads:[~2016-12-20 10:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-19 17:27 Will Schmidt
2016-12-20 10:48 ` Richard Biener [this message]
2016-12-20 11:26   ` Jakub Jelinek
2017-05-11 15:53 Will Schmidt
2017-05-12  7:26 ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFiYyc3xxrqoKmWfG4cT38iYkRCfwosaG=CC28KU+8EUwwvdvg@mail.gmail.com' \
    --to=richard.guenther@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=will_schmidt@vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).