From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27335 invoked by alias); 8 Oct 2012 09:08:28 -0000 Received: (qmail 27281 invoked by uid 22791); 8 Oct 2012 09:08:27 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-oa0-f47.google.com (HELO mail-oa0-f47.google.com) (209.85.219.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Oct 2012 09:08:18 +0000 Received: by mail-oa0-f47.google.com with SMTP id h1so3968669oag.20 for ; Mon, 08 Oct 2012 02:08:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.28.6 with SMTP id x6mr13075123oeg.61.1349687297916; Mon, 08 Oct 2012 02:08:17 -0700 (PDT) Received: by 10.76.95.202 with HTTP; Mon, 8 Oct 2012 02:08:17 -0700 (PDT) In-Reply-To: <50705457.5030505@naturalbridge.com> References: <506C72C7.7090207@naturalbridge.com> <506D9544.7020408@naturalbridge.com> <506DD085.7080608@naturalbridge.com> <87txuaox52.fsf@talisman.home> <87lifli6oj.fsf@sandifor-thinkpad.stglab.manchester.uk.ibm.com> <87ehldi2kr.fsf@sandifor-thinkpad.stglab.manchester.uk.ibm.com> <87a9w1hzq1.fsf@sandifor-thinkpad.stglab.manchester.uk.ibm.com> <506F0C1A.5010705@naturalbridge.com> <87lifkhlo9.fsf@sandifor-thinkpad.stglab.manchester.uk.ibm.com> <506F5B50.2040800@naturalbridge.com> <506F63CC.40507@naturalbridge.com> <50705457.5030505@naturalbridge.com> Date: Mon, 08 Oct 2012 09:08:00 -0000 Message-ID: Subject: Re: patch to fix constant math - third small patch From: Richard Guenther To: Kenneth Zadeck Cc: Mike Stump , gcc-patches , rdsandiford@googlemail.com Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-10/txt/msg00724.txt.bz2 On Sat, Oct 6, 2012 at 5:55 PM, Kenneth Zadeck wrote: > This is the third patch in the series of patches to fix constant math. > this one changes some predicates at the rtl level to use the new predicate > CONST_SCALAR_INT_P. > I did not include a few that were tightly intertwined with other changes. > > Not all of these changes are strictly mechanical. Richard, when reviewing > this had me make additional changes to remove what he thought were latent > bugs at the rtl level. However, it appears that the bugs were not latent. > I do not know what is going on here but i am smart enough to not look a gift > horse in the mouth. > > All of this was done on the same machine with no changes and identical > configs. It is an x86-64 with ubuntu 12-4. > > ok for commit? Patch missing, but if it's just mechanical changes and introduction of CONST_SCALAR_INT_P consider it pre-approved. Richard. > in the logs below, gbBaseline is a trunk from friday and the gbWide is the > same revision but with my patches. Some of this like gfortran.dg/pr32627 is > obviously flutter, but the rest does not appear to be. > > ========= > heracles:~/gcc(13) gccBaseline/contrib/compare_tests > gbBaseline/gcc/testsuite/gcc/gcc.log gbWide/gcc/testsuite/gcc/gcc.log > New tests that PASS: > > gcc.dg/builtins-85.c scan-assembler mysnprintf > gcc.dg/builtins-85.c scan-assembler-not __chk_fail > gcc.dg/builtins-85.c (test for excess errors) > > > heracles:~/gcc(14) gccBaseline/contrib/compare_tests > gbBaseline/gcc/testsuite/gfortran/gfortran.log > gbWide/gcc/testsuite/gfortran/gfortran.log > New tests that PASS: > > gfortran.dg/pr32627.f03 -O3 -fomit-frame-pointer -funroll-loops (test for > excess errors) > gfortran.dg/pr32627.f03 -O3 -fomit-frame-pointer (test for excess errors) > gfortran.dg/pr32627.f03 -Os (test for excess errors) > gfortran.dg/pr32635.f -O0 execution test > gfortran.dg/pr32635.f -O0 (test for excess errors) > gfortran.dg/substr_6.f90 -O2 (test for excess errors) > > Old tests that passed, that have disappeared: (Eeek!) > > gfortran.dg/pr32627.f03 -O1 (test for excess errors) > gfortran.dg/pr32627.f03 -O3 -fomit-frame-pointer -funroll-all-loops > -finline-functions (test for excess errors) > gfortran.dg/pr32627.f03 -O3 -g (test for excess errors) > gfortran.dg/substring_equivalence.f90 -O (test for excess errors) > Using /home/zadeck/gcc/gccBaseline/gcc/testsuite/config/default.exp as > tool-and-target-specific interface file. > > === g++ Summary === > > # of expected passes 49793 > # of expected failures 284 > # of unsupported tests 601 > > runtest completed at Fri Oct 5 16:10:20 2012 > heracles:~/gcc(16) tail gbWide/gcc/testsuite/g++/g++.log Using > /usr/share/dejagnu/config/unix.exp as generic interface file for target. > Using /home/zadeck/gcc/gccWide/gcc/testsuite/config/default.exp as > tool-and-target-specific interface file. > > === g++ Summary === > > # of expected passes 50472 > # of expected failures 284 > # of unsupported tests 613 > > runtest completed at Fri Oct 5 19:51:50 2012 > > > > >