From: Ville Voutilainen <ville.voutilainen@gmail.com>
To: Glen Fernandes <glen.fernandes@gmail.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix overflow handling in std::align
Date: Mon, 14 Sep 2020 17:30:13 +0300 [thread overview]
Message-ID: <CAFk2RUY0RR7ph2LaMN3WLAdiWXjuQLb0KvRdSSr8ihHnFBXFjg@mail.gmail.com> (raw)
In-Reply-To: <CAHVPgzn2mNk4tXwUWuaa28RcysiDkmRPDEmQfBMztxiqmvuiew@mail.gmail.com>
On Mon, 14 Sep 2020 at 15:49, Glen Fernandes <glen.fernandes@gmail.com> wrote:
>
> On Mon, Sep 14, 2020 at 5:52 AM Ville Voutilainen wrote:
> > On Mon, 14 Sep 2020 at 12:51, Ville Voutilainen
> > wrote:
> > > On Mon, 14 Sep 2020 at 09:18, Glen Fernandes
> > wrote:
> > > > Edit; Correct patch this time.
> > > >
> > > > Fix overflow handling in align
> > >
> > > Should the test verify that space is unmodified when nullptr is returned?
> >
> > ..and same for ptr.
>
> Sounds like a good idea. Updated patch attached.
Looks good to me.
next prev parent reply other threads:[~2020-09-14 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 6:17 Glen Fernandes
2020-09-14 9:51 ` Ville Voutilainen
2020-09-14 9:51 ` Ville Voutilainen
2020-09-14 12:49 ` Glen Fernandes
2020-09-14 14:30 ` Ville Voutilainen [this message]
2020-09-14 21:44 ` Thomas Rodgers
2020-09-21 14:42 ` Glen Fernandes
2020-09-21 14:50 ` Jonathan Wakely
2020-09-22 17:09 ` Jonathan Wakely
-- strict thread matches above, loose matches on Subject: below --
2020-09-14 5:30 Glen Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFk2RUY0RR7ph2LaMN3WLAdiWXjuQLb0KvRdSSr8ihHnFBXFjg@mail.gmail.com \
--to=ville.voutilainen@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=glen.fernandes@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).