From: Ville Voutilainen <ville.voutilainen@gmail.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: Paolo Carlini <paolo.carlini@oracle.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [v3 PATCH] Make the default constructors of tuple and pair conditionally explicit.
Date: Tue, 03 Nov 2015 14:49:00 -0000 [thread overview]
Message-ID: <CAFk2RUZ7PNtRkyEp3PGQ99aeFjm9t0WKtonw80L=CrspmdQWnw@mail.gmail.com> (raw)
In-Reply-To: <CAH6eHdQL4tCDtYZ8ZdU7DQ_JnmCrO83t-OYckcDOR7_JyQDYkg@mail.gmail.com>
On 3 November 2015 at 16:42, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> On 3 November 2015 at 02:37, Paolo Carlini wrote:
>> Hi,
>>
>> On 11/02/2015 09:20 PM, Ville Voutilainen wrote:
>>>
>>> On 2 November 2015 at 21:20, Paolo Carlini <paolo.carlini@oracle.com>
>>> wrote:
>>>>
>>>> Can we follow the terse style already used elsewhere (eg,
>>>> __is_direct_constructible_new_safe) thus directly inherit from __and_ and
>>>> avoid explicit integral_constant? Otherwise patch looks good to me.
>>>
>>>
>>> Sure. Tested again on Linux-PPC64, tests adjusted due to line changes,
>>> Changelog entry updated to have a correct date on it.
>>
>> Great, thanks a lot. Thinking more about this detail, I wonder if we should
>> therefore apply the below too? Anything I'm missing?
>
> I have a weak preference for deriving from xxx::type rather than xxx,
> so that the traits derive directly from either true_type or
> false_type, not indirectly via some other type that derives from
> true_type or false_type, but it probably isn't important.
I expect the inheritance hierarchies of these things to be linear, so
probably not
a huge matter. I did push the patch already. :)
prev parent reply other threads:[~2015-11-03 14:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-01 3:27 Ville Voutilainen
2015-11-02 15:19 ` Paolo Carlini
2015-11-02 17:00 ` Ville Voutilainen
2015-11-02 19:20 ` Paolo Carlini
2015-11-02 20:20 ` Ville Voutilainen
2015-11-02 21:07 ` Paolo Carlini
2015-11-03 5:02 ` Ville Voutilainen
2015-11-03 8:32 ` Paolo Carlini
2015-11-03 14:43 ` Jonathan Wakely
2015-11-03 14:49 ` Ville Voutilainen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFk2RUZ7PNtRkyEp3PGQ99aeFjm9t0WKtonw80L=CrspmdQWnw@mail.gmail.com' \
--to=ville.voutilainen@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).