From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121397 invoked by alias); 21 Sep 2016 19:42:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 121378 invoked by uid 89); 21 Sep 2016 19:42:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=cook X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-yw0-f193.google.com Received: from mail-yw0-f193.google.com (HELO mail-yw0-f193.google.com) (209.85.161.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Sep 2016 19:42:11 +0000 Received: by mail-yw0-f193.google.com with SMTP id g192so3676202ywh.0; Wed, 21 Sep 2016 12:42:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=d1T/T2Z0Yg17xKIeEt4AcWYZBBwVYU6O1V7Frl3kOi4=; b=XqF5v/C/QupznAgcDE6axzxjzIDqXAsPBAwOulaTIbeRtdlKDcTEaajOW717ftNann KWmWisi0XXFXOGJaY3ZYcwPc/aB2Dy6dpfLlIYP6nq0J8tnlD7C+nuJwCbyiLGIt9Hh7 oGzSb0rsRE0+4SgWXwLEoBZb/zSHl/9ELOTnDZR8O03YekDddq4bOWvMPq/g2nCib3SO ladCOK3J/2mMofUlOri1OLKOWe65cBh7giHcowq5cdnHExSYfjtDK/f2AKqPXnxrjW8J rZTlyZua2vwoL2cAsJbV9qQTXTJVsP0IvNLujHwk+kjYRwi9qns4Onr8S/mENTj1CcMG czKQ== X-Gm-Message-State: AE9vXwNqrqVm5I8Ei2Y/oyKCleVV7D0q4n9fKLEA63h7W4N3XzoMAYH8LbW4x5sYl8Dy0FVo1cG5s02r8rkk8w== X-Received: by 10.129.157.17 with SMTP id u17mr35372145ywg.40.1474486929510; Wed, 21 Sep 2016 12:42:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.104.193 with HTTP; Wed, 21 Sep 2016 12:42:08 -0700 (PDT) In-Reply-To: <20160921093115.GI17376@redhat.com> References: <20160921093115.GI17376@redhat.com> From: Ville Voutilainen Date: Wed, 21 Sep 2016 19:51:00 -0000 Message-ID: Subject: Re: [v3 PATCH] PR libstdc++/77288 and the newest proposed resolution for LWG 2756 To: Jonathan Wakely Cc: "libstdc++" , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-09/txt/msg01461.txt.bz2 On 21 September 2016 at 12:31, Jonathan Wakely wrote: > On 06/09/16 09:00 +0300, Ville Voutilainen wrote: >> >> PR libstdc++/77288 >> * include/std/optional (__is_optional_impl, __is_optional): Remove. >> (__converts_from_optional, __assigns_from_optional): New. >> (optional(_Up&&)): Use is_same instead of __is_optional. >> (optional(const optional<_Up>&)): Constrain with >> __converts_from_optional. >> (optional(optional<_Up>&&)): Likewise. >> (operator=(_Up&&)): Use is_same instead of __is_optional, check >> is_same and is_scalar. >> (operator=(const optional<_Up>&)): Constrain with >> __converts_from_optional and __assigns_from_optional. >> (operator=(optional<_Up>&&)): Likewise. >> * testsuite/20_util/optional/77288.cc: New. >> * testsuite/20_util/optional/cons/value.cc: Adjust. > > > OK for trunk, thanks. Thanks, applied - I will cook up a separate patch for making the same fix for experimental::optional. The plan is to then backport that one to the gcc-6 branch.