From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by sourceware.org (Postfix) with ESMTPS id 09E403857C52; Sat, 10 Oct 2020 11:15:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 09E403857C52 Received: by mail-qt1-x842.google.com with SMTP id o21so10119610qtp.2; Sat, 10 Oct 2020 04:15:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A+hRwvOtYCObK+5UyDpITrWNiyN6v5urLUWSB3AUI+0=; b=MuXYhfZ/yfkCZbAEB/YLQyII4GL2wwKmp6me7mUR4I7MnetTLWxSJFcZ1RLezVMSCN +5JrsIKqbzoAhnEuFoAju314cF39lbx5GcN4+cbGA6lCnTJdI+2g+9F/I2gIxQTqjwLg uElkJ3jowhTg98R4h1bMRK19Kub2bGeJYGo3guOJ/cbiHrezFg/Ncl3xoLOW9gk8UtHn IoLQTICMXNmf5tSFWMhdvrwKT3vZRdX52PS9SCldto40smsyd8jMRsyjcq/Nw2mqVy9t lGjpbcBevhVqJx5zLaly8h4E8uCaR1cQDQnIUY8XTUUQ/K+Dyz0C0y91/Sel7SDy9Ejo Rfgw== X-Gm-Message-State: AOAM531CPrfuc8BGPHodijj5vKYXVOp6VNQsPJgsdIrj69FVk9BXQujx TP9pLt3L/3XYwGTOFR18GLCc+BnshUPAbqSCcmQ= X-Google-Smtp-Source: ABdhPJwUuBdxdXyhiG1FpOGJ09ne304i6H+tsOEQjscbalCQH6G6hKF1IVsPKGfJ4zgm4KdVIfHM6W6ARou/NjLA2OM= X-Received: by 2002:ac8:4808:: with SMTP id g8mr2003805qtq.18.1602328541819; Sat, 10 Oct 2020 04:15:41 -0700 (PDT) MIME-Version: 1.0 References: <20200929112043.GL3946@redhat.com> <20201002221434.GC3426@redhat.com> <20201010105232.GS7004@redhat.com> In-Reply-To: <20201010105232.GS7004@redhat.com> From: Ville Voutilainen Date: Sat, 10 Oct 2020 14:15:30 +0300 Message-ID: Subject: Re: [PATCH] libstdc++: Diagnose visitors with different return types [PR95904] To: Jonathan Wakely Cc: "libstdc++" , gcc-patches List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_LINKBAIT3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Oct 2020 11:15:44 -0000 On Sat, 10 Oct 2020 at 13:52, Jonathan Wakely wrote: > index_sequence uses size_t not unsigned long. This parameter pack > needs to be size_t... _Idxs, and the NTTP for __check_visitor_result > should be size_t _Idx. Fixed in https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=02cbd79e4728319e0887ad7783297853b527bb13 after approval-over-irc.