public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ville Voutilainen <ville.voutilainen@gmail.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: Jonathan Wakely <jwakely@redhat.com>,
	"libstdc++" <libstdc++@gcc.gnu.org>,
		"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [v3 PATCH] PR libstdc++/77288 and the newest proposed resolution for LWG 2756
Date: Thu, 22 Sep 2016 09:21:00 -0000	[thread overview]
Message-ID: <CAFk2RUaty3ufSvgXshKTt0V6vk458AXnWWxoA_J34bVNOdgg9w@mail.gmail.com> (raw)
In-Reply-To: <CAKdteOa0_mrBFvi0QTX7bdNZi-O21+wM6Xdw2vWFNOBdPVuC4Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

On 22 September 2016 at 11:55, Christophe Lyon
<christophe.lyon@linaro.org> wrote:
> The new test 77288.cc fails on old arm targets (armv5t):
> /aci-gcc-fsf/sources/gcc-fsf/gccsrc/libstdc++-v3/testsuite/20_util/optional/77288.cc:
> In function 'void test01()':
> /aci-gcc-fsf/sources/gcc-fsf/gccsrc/libstdc++-v3/testsuite/20_util/optional/77288.cc:31:
> error: 'exception_ptr' is not a member of 'std'
> /aci-gcc-fsf/sources/gcc-fsf/gccsrc/libstdc++-v3/testsuite/20_util/optional/77288.cc:31:
> error: template argument 1 is invalid
> /aci-gcc-fsf/sources/gcc-fsf/gccsrc/libstdc++-v3/testsuite/20_util/optional/77288.cc:31:
> error: template argument 1 is invalid
> /aci-gcc-fsf/sources/gcc-fsf/gccsrc/libstdc++-v3/testsuite/20_util/optional/77288.cc:32:
> error: 'exception_ptr' is not a member of 'std'
> /aci-gcc-fsf/sources/gcc-fsf/gccsrc/libstdc++-v3/testsuite/20_util/optional/77288.cc:32:
> error: template argument 1 is invalid


Does the attached patch fix the problem?

[-- Attachment #2: 77288-test-fix.diff --]
[-- Type: text/x-patch, Size: 736 bytes --]

diff --git a/libstdc++-v3/testsuite/20_util/optional/77288.cc b/libstdc++-v3/testsuite/20_util/optional/77288.cc
index eafafb7..0df74a9 100644
--- a/libstdc++-v3/testsuite/20_util/optional/77288.cc
+++ b/libstdc++-v3/testsuite/20_util/optional/77288.cc
@@ -18,7 +18,6 @@
 // with this library; see the file COPYING3.  If not see
 // <http://www.gnu.org/licenses/>.
 
-#include <exception>
 #include <optional>
 #include <any>
 
@@ -28,8 +27,8 @@ using std::optional;
 
 void test01()
 {
-    optional<optional<std::exception_ptr>> nested_element;
-    optional<std::exception_ptr> element = {};
+    optional<optional<int>> nested_element;
+    optional<int> element = {};
     nested_element = element;
     VERIFY(nested_element);
 }

  reply	other threads:[~2016-09-22  9:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23 14:17 Ville Voutilainen
2016-09-06  7:05 ` Ville Voutilainen
2016-09-21  9:43   ` Jonathan Wakely
2016-09-21 19:51     ` Ville Voutilainen
2016-09-22  9:01       ` Christophe Lyon
2016-09-22  9:21         ` Ville Voutilainen [this message]
2016-09-22  9:43           ` Christophe Lyon
2016-09-22 10:03             ` Ville Voutilainen
2016-09-22 10:36               ` Jonathan Wakely
2016-09-22 11:38                 ` Jonathan Wakely
2016-09-22 13:32                   ` Jonathan Wakely
2016-09-22 19:10                     ` Christophe Lyon
2016-09-23 10:48                       ` Jonathan Wakely
2016-09-27  0:22                         ` Christophe Lyon
2016-09-22 20:32                   ` Christophe Lyon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFk2RUaty3ufSvgXshKTt0V6vk458AXnWWxoA_J34bVNOdgg9w@mail.gmail.com \
    --to=ville.voutilainen@gmail.com \
    --cc=christophe.lyon@linaro.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).