From: Ville Voutilainen <ville.voutilainen@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [v3 PATCH] Implement std::is_aggregate.
Date: Sun, 02 Apr 2017 09:24:00 -0000 [thread overview]
Message-ID: <CAFk2RUbHjgrbYe_EZdjggweS0c=VkC1AGK5NCgh4SosHczVFJA@mail.gmail.com> (raw)
In-Reply-To: <20170402053514.GZ17461@tucnak>
On 2 April 2017 at 08:35, Jakub Jelinek <jakub@redhat.com> wrote:
>> + remove_cv_t<_Tp>
>> + )>
>
> Any reason for the wrapping?
No, it's just a result of a nocturnal copy-paste-job of the existing
code for has_unique_object_representations.
> Also, shouldn't there be also:
>
> /// is_aggregate_v
> template<typename _Tp>
> _GLIBCXX17_INLINE constexpr bool is_aggregate_v =
> is_aggregate<_Tp>::value;
>
> somewhere with appropriate guards (or within the same ones)?
Yes, well spotted. I will add that.
> I'm surprised tests for the is_*_v variable templates are only in
> experimental/type_traits/value.cc when they are now apparently
> part of C++17.
Perhaps 20_util/variable_templates_for_traits.cc ?
next prev parent reply other threads:[~2017-04-02 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 22:19 Ville Voutilainen
2017-04-02 5:35 ` Jakub Jelinek
2017-04-02 9:24 ` Ville Voutilainen [this message]
2017-04-02 11:08 ` Jakub Jelinek
2017-04-02 12:08 ` Ville Voutilainen
2017-04-03 15:32 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFk2RUbHjgrbYe_EZdjggweS0c=VkC1AGK5NCgh4SosHczVFJA@mail.gmail.com' \
--to=ville.voutilainen@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).