public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ville Voutilainen <ville.voutilainen@gmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	"libstdc++" <libstdc++@gcc.gnu.org>,
		Jason Merrill <jason@redhat.com>
Subject: [C++ PATCH] PR c++/80812
Date: Thu, 25 May 2017 09:52:00 -0000	[thread overview]
Message-ID: <CAFk2RUbhjh3RGDOEurUrF6H5j95VyMXR3F43noDij0mD5Q3Gaw@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Tested on Linux-x64, running full suite on Linux-ppc64. It seems fitting
to put the test into the library tests, we don't have separate tests
on the front-end side for __is_constructible, so I think adding such
would be a separate job.

2017-05-25  Ville Voutilainen  <ville.voutilainen@gmail.com>

    cp/

    PR c++/80812
    * method.c (constructible_expr): Strip array types before calling
    build_value_init.

    libstdc++/

    PR c++/80812
    * testsuite/20_util/is_constructible/80812.cc: New.

[-- Attachment #2: 80812.diff --]
[-- Type: text/plain, Size: 1685 bytes --]

diff --git a/gcc/cp/method.c b/gcc/cp/method.c
index 8aa4f3e..aa607d5 100644
--- a/gcc/cp/method.c
+++ b/gcc/cp/method.c
@@ -1188,7 +1188,7 @@ constructible_expr (tree to, tree from)
   else
     {
       if (from == NULL_TREE)
-	return build_value_init (to, tf_none);
+	return build_value_init (strip_array_types (to), tf_none);
       else if (TREE_CHAIN (from))
 	return error_mark_node; // too many initializers
       from = build_stub_object (TREE_VALUE (from));
diff --git a/libstdc++-v3/testsuite/20_util/is_constructible/80812.cc b/libstdc++-v3/testsuite/20_util/is_constructible/80812.cc
new file mode 100644
index 0000000..17af9ae
--- /dev/null
+++ b/libstdc++-v3/testsuite/20_util/is_constructible/80812.cc
@@ -0,0 +1,29 @@
+// { dg-do compile { target c++11 } }
+// Copyright (C) 2017 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+//
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <type_traits>
+
+struct X
+{
+  X() {}
+};
+
+void test01()
+{
+  static_assert(std::is_constructible<X[4]>::value);
+}

             reply	other threads:[~2017-05-25  9:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25  9:52 Ville Voutilainen [this message]
2017-05-31 20:37 ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFk2RUbhjh3RGDOEurUrF6H5j95VyMXR3F43noDij0mD5Q3Gaw@mail.gmail.com \
    --to=ville.voutilainen@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).