From: Sebastian Pop <sebpop@gmail.com>
To: Richard Biener <rguenther@suse.de>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][GRAPHITE] Fix PR80906, code-gen IVs in loop-closed position
Date: Tue, 30 May 2017 13:35:00 -0000 [thread overview]
Message-ID: <CAFk3UF-KT3rz2BAErWAt9+s=AZoTNzdmNzDyn0yjQ=+C1CiqMA@mail.gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.20.1705301453540.20726@zhemvz.fhfr.qr>
On Tue, May 30, 2017 at 7:56 AM, Richard Biener <rguenther@suse.de> wrote:
>
> We currently ICE when code generating loop-closed PHIs that are after-loop
> used IVs. I didn't manage to find the place during analysis that is
> supposed to reject such SCOPs thus the following patch "simply" makes
> us properly generate code for those (works fine on the testcase).
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, ok?
The change looks good to me. Thanks!
>
> If there's such rejection code it might be lifted now (and eventually
> unconver the bugs I introduce with this patch).
>
I don't think we have any filter in the front-end of graphite to
discard those cases.
Thanks,
Sebastian
prev parent reply other threads:[~2017-05-30 13:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 13:10 Richard Biener
2017-05-30 13:35 ` Sebastian Pop [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFk3UF-KT3rz2BAErWAt9+s=AZoTNzdmNzDyn0yjQ=+C1CiqMA@mail.gmail.com' \
--to=sebpop@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).