From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43044 invoked by alias); 30 May 2017 13:28:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 43032 invoked by uid 89); 30 May 2017 13:28:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=HTo:U*rguenther X-HELO: mail-oi0-f53.google.com Received: from mail-oi0-f53.google.com (HELO mail-oi0-f53.google.com) (209.85.218.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 May 2017 13:28:23 +0000 Received: by mail-oi0-f53.google.com with SMTP id h4so110850401oib.3 for ; Tue, 30 May 2017 06:28:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=k6r+dYmKyha3IHjKOj1ONU+6RIgfLkT1w/4EVTSF4yQ=; b=pPbV+3hWJzVrZ+kWThJRFnVNDdxE4G6yXaJPUEJupTULucZ/J6oqxN/fmlPVDSqvC0 7MKBdU5PNdHza6yvbf894qcrMIleX4y/wnjF3f67pia3YoGvJKe6Io7r3fBBtSJKwmx+ 5PeTCy49IxKDXNaPwehP+mHhytwbZvGRlUdq6Ls4Z57Ad7r2PX9QlZ/J5PbGBLQ4k1O0 zFd0+0XIq6m/o5Mb4zm2AV9m0NAStz1hGfh7mkbmHm5qzChy847ffSDs1GrW0W2tW/Dp aq/0n0vEBGBzbu8Vfso4PXKizgFWk7h69Yhz8mksjHN2LWdpQDi7YC+pG7IR4zUJI815 hHFQ== X-Gm-Message-State: AODbwcAPxTlsu7rDoZN0qLqY6+LqwEHYyS0lIC+zv8GWZhJeq0ykxtx0 Cz/HNf9xH8L3aJSFteydQPTm+IqxLA== X-Received: by 10.202.232.143 with SMTP id f137mr7939535oih.33.1496150905496; Tue, 30 May 2017 06:28:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.50.181 with HTTP; Tue, 30 May 2017 06:27:44 -0700 (PDT) In-Reply-To: References: From: Sebastian Pop Date: Tue, 30 May 2017 13:35:00 -0000 Message-ID: Subject: Re: [PATCH][GRAPHITE] Fix PR80906, code-gen IVs in loop-closed position To: Richard Biener Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg02273.txt.bz2 On Tue, May 30, 2017 at 7:56 AM, Richard Biener wrote: > > We currently ICE when code generating loop-closed PHIs that are after-loop > used IVs. I didn't manage to find the place during analysis that is > supposed to reject such SCOPs thus the following patch "simply" makes > us properly generate code for those (works fine on the testcase). > > Bootstrapped and tested on x86_64-unknown-linux-gnu, ok? The change looks good to me. Thanks! > > If there's such rejection code it might be lifted now (and eventually > unconver the bugs I introduce with this patch). > I don't think we have any filter in the front-end of graphite to discard those cases. Thanks, Sebastian