From: Sebastian Pop <sebpop@gmail.com>
To: Tobias Grosser <tobias@grosser.es>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [graphite] Move to cloog.org interface
Date: Thu, 11 Aug 2011 05:44:00 -0000 [thread overview]
Message-ID: <CAFk3UF-xKmG_Vg+D3W4qyVAZO96KSHJUmeC8EmCuhJqu00zArw@mail.gmail.com> (raw)
In-Reply-To: <4E42FFA4.6080102@grosser.es>
Hi Tobi,
The patch looks good modulo some formatting changes:
+ free(c->free_name);
+ int length = strlen(e->name);
[...]
Please follow the GNU style: there should be a space between the
function name and the open parenthesis.
- dom = new_Cloog_Domain_from_ppl_Pointset_Powerset (PBB_DOMAIN (pbb),
+ domain = new_Cloog_Domain_from_ppl_Pointset_Powerset (PBB_DOMAIN (pbb),
scop_nb_params (scop),
cloog_state);
You would still need proper indentation on the last two lines.
+ /* Dump a .cloog input file, if requested. This feature is only
+ * enabled in the Graphite branch. */
Please remove the * from the beginning of the new line in this comment.
Ok with these changes and after the other patches are committed.
Thanks,
Sebastian
next prev parent reply other threads:[~2011-08-10 22:42 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 23:09 Tobias Grosser
2011-08-11 5:44 ` Sebastian Pop [this message]
2011-08-11 18:13 ` Tobias Grosser
2011-08-11 18:24 ` Sebastian Pop
2011-08-11 18:29 ` Tobias Grosser
2011-08-11 19:02 ` Sebastian Pop
2011-08-11 20:11 ` Tobias Grosser
2011-08-11 20:56 ` Sebastian Pop
2011-08-11 22:45 ` Sven Verdoolaege
2011-08-11 22:00 ` Sven Verdoolaege
2011-08-11 20:24 ` Sven Verdoolaege
2011-08-11 20:54 ` Sebastian Pop
2011-08-11 22:06 ` Sven Verdoolaege
2011-08-11 22:45 ` Sebastian Pop
2011-08-11 22:45 ` Sebastian Pop
2011-08-11 22:45 ` Sven Verdoolaege
2011-08-11 22:45 ` [PATCH 00/11] Partial conversion of Graphite to ISL Sebastian Pop
2011-08-11 22:45 ` [PATCH 05/11] Move to new Cloog interface Sebastian Pop
2011-08-11 22:45 ` [PATCH 04/11] Document CLooG-ISL requirement for Graphite Sebastian Pop
2011-08-11 22:45 ` [PATCH 10/11] add pbb->domain Sebastian Pop
2011-08-11 22:45 ` [PATCH 06/11] Remove ATTRIBUTE_UNUSED Sebastian Pop
2011-08-11 22:45 ` [PATCH 03/11] Remove code that supported legacy CLooG Sebastian Pop
2011-08-11 22:45 ` [PATCH 02/11] Require cloog 0.16.3 Sebastian Pop
2011-08-11 23:18 ` [PATCH 09/11] Add scop->context Sebastian Pop
2011-08-12 2:41 ` Jack Howarth
2011-08-12 7:21 ` Sebastian Pop
2011-08-12 7:22 ` Jack Howarth
2011-08-12 9:15 ` Tobias Grosser
2011-08-12 9:19 ` Sven Verdoolaege
2011-08-12 15:18 ` Sebastian Pop
2011-08-12 15:42 ` [PATCH 1/2] use cloog_isl_state_malloc Sebastian Pop
2011-08-12 15:50 ` [PATCH 2/2] document ISL requirement for GCC installation Sebastian Pop
2011-08-12 16:04 ` Sven Verdoolaege
2011-08-12 17:32 ` Joseph S. Myers
2011-08-12 19:18 ` Sven Verdoolaege
2011-08-12 19:22 ` Jack Howarth
2011-08-12 19:54 ` Sebastian Pop
2011-08-12 19:27 ` Joseph S. Myers
2011-08-12 19:29 ` Sven Verdoolaege
2011-08-12 19:30 ` Joseph S. Myers
2011-08-12 19:40 ` Sven Verdoolaege
2011-08-12 20:29 ` Joseph S. Myers
2011-08-12 21:15 ` Sven Verdoolaege
2011-08-13 20:12 ` Joseph S. Myers
2011-08-14 2:27 ` Sebastian Pop
2011-08-14 8:09 ` Jack Howarth
2011-08-14 8:15 ` Matthias Klose
2011-08-14 8:27 ` Sebastian Pop
2011-08-14 16:23 ` Richard Guenther
2011-08-15 15:20 ` Michael Matz
2011-08-12 21:02 ` Jack Howarth
2011-08-12 21:35 ` Sven Verdoolaege
2011-08-11 23:27 ` [PATCH 01/11] Make CLooG-ISL the only supported CLooG version Sebastian Pop
2011-08-12 0:02 ` [PATCH 08/11] Add ISL data structures Sebastian Pop
2011-08-12 8:42 ` Sven Verdoolaege
2011-08-12 0:07 ` [PATCH 07/11] fix memory leak Sebastian Pop
2011-08-12 0:07 ` [PATCH 11/11] add pdr->accesses and pdr->extent Sebastian Pop
2011-08-12 15:25 ` [PATCH] add pbb->schedule Sebastian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFk3UF-xKmG_Vg+D3W4qyVAZO96KSHJUmeC8EmCuhJqu00zArw@mail.gmail.com \
--to=sebpop@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@grosser.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).