public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Sebastian Pop <sebpop@gmail.com>
To: Tom de Vries <Tom_deVries@mentor.com>
Cc: Tobias Grosser <tobias@grosser.es>,
	"gcc-patches@gnu.org" <gcc-patches@gnu.org>
Subject: Re: [PATCH, PR68976] Use reaching def phi arg in sese_add_exit_phis_edge
Date: Fri, 15 Jan 2016 17:19:00 -0000	[thread overview]
Message-ID: <CAFk3UF834TY4HTgEwrP8iPEcaoAq0k==ZyLc9n+6cX8R06xYxg@mail.gmail.com> (raw)
In-Reply-To: <5698FB0F.3090908@mentor.com>

On Fri, Jan 15, 2016 at 7:58 AM, Tom de Vries <Tom_deVries@mentor.com> wrote:
> During scop detection/canonicalize_loop_closed_ssa_form, an exit phi is
> introduced in the loop for _24:
> ...
>   <bb 21>:
>   # _58 = PHI <_24(22)>
> ...
> Note that _24 is not defined in the loop, but before it. AFAIU the header
> comment of canonicalize_loop_closed_ssa_form, this phi is not needed. That
> might be the root cause of the bug,

I think that may be the problem, as it is invariant in the loops, so
it is considered to be a parameter of the scop.
Let me see if we could avoid adding that phi node in the first place.

  reply	other threads:[~2016-01-15 17:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-15 13:58 Tom de Vries
2016-01-15 17:19 ` Sebastian Pop [this message]
2016-01-15 19:58   ` Sebastian Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFk3UF834TY4HTgEwrP8iPEcaoAq0k==ZyLc9n+6cX8R06xYxg@mail.gmail.com' \
    --to=sebpop@gmail.com \
    --cc=Tom_deVries@mentor.com \
    --cc=gcc-patches@gnu.org \
    --cc=tobias@grosser.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).