From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67369 invoked by alias); 15 Jan 2016 17:19:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 67352 invoked by uid 89); 15 Jan 2016 17:19:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Tom_deVries@mentor.com, tom_devries@mentor.com, Tom_deVriesmentorcom, tom_devriesmentorcom X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 15 Jan 2016 17:19:57 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42640) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1aK82U-0005XF-Gl for gcc-patches@gnu.org; Fri, 15 Jan 2016 12:19:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK82T-0007Iu-AV for gcc-patches@gnu.org; Fri, 15 Jan 2016 12:19:54 -0500 Received: from mail-ig0-x233.google.com ([2607:f8b0:4001:c05::233]:37788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK82T-0007Ih-5G for gcc-patches@gnu.org; Fri, 15 Jan 2016 12:19:53 -0500 Received: by mail-ig0-x233.google.com with SMTP id h5so14227433igh.0 for ; Fri, 15 Jan 2016 09:19:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=5DgKvB9ODsb6MOrUx6Mg/zHENEAvxLZPvqvay1Fz2Og=; b=AWqEdPjq//ZqAaxRWTgwYgBVs8Ap8PsIhlYwHw8yX+sxIrLK2YYjJjWOE2K5c0YbTI FNal9m2IUmm5gbgGRPwxYLCW6YyWt3rD8UOzIndTrOrodCRle80JsOFuGOTR3NQFjTe3 ADQjhoZiT+icWjAddPoSUoTg2yIr6zgpJ1j4ffGrutlWFd48O4348naQLWeXkh6pbB1t oy+uiCI5NondsXqXFWEWICrs7SAuaDWzUDZQoLYmAL+dx1jDEhpeVz5qZ8apaX6hk884 vuzOGxei2taJvq/1DDXV4JXv84bTt0HUtT/I1Nq6C26CofIy2b3HiRVYLWVz1gIcIKg2 Ibew== X-Gm-Message-State: AG10YOT9uzHRqAS5FxZG/OkLviONs2OmwUEUJYHa6yG4Iw7pAtN5jXJ4vsAtf0Ie9xGvcynTwYQVRCur4VLXEw== X-Received: by 10.50.129.97 with SMTP id nv1mr4490257igb.0.1452878392221; Fri, 15 Jan 2016 09:19:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.97 with HTTP; Fri, 15 Jan 2016 09:19:12 -0800 (PST) In-Reply-To: <5698FB0F.3090908@mentor.com> References: <5698FB0F.3090908@mentor.com> From: Sebastian Pop Date: Fri, 15 Jan 2016 17:19:00 -0000 Message-ID: Subject: Re: [PATCH, PR68976] Use reaching def phi arg in sese_add_exit_phis_edge To: Tom de Vries Cc: Tobias Grosser , "gcc-patches@gnu.org" Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c05::233 X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg01112.txt.bz2 On Fri, Jan 15, 2016 at 7:58 AM, Tom de Vries wrote: > During scop detection/canonicalize_loop_closed_ssa_form, an exit phi is > introduced in the loop for _24: > ... > : > # _58 = PHI <_24(22)> > ... > Note that _24 is not defined in the loop, but before it. AFAIU the header > comment of canonicalize_loop_closed_ssa_form, this phi is not needed. That > might be the root cause of the bug, I think that may be the problem, as it is invariant in the loops, so it is considered to be a parameter of the scop. Let me see if we could avoid adding that phi node in the first place.