From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105854 invoked by alias); 22 Nov 2015 03:21:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 86338 invoked by uid 89); 22 Nov 2015 03:14:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f174.google.com Received: from mail-ig0-f174.google.com (HELO mail-ig0-f174.google.com) (209.85.213.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 22 Nov 2015 03:14:39 +0000 Received: by igcto18 with SMTP id to18so36745882igc.0 for ; Sat, 21 Nov 2015 19:14:37 -0800 (PST) X-Received: by 10.50.160.33 with SMTP id xh1mr8076325igb.25.1448162077489; Sat, 21 Nov 2015 19:14:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.67 with HTTP; Sat, 21 Nov 2015 19:13:58 -0800 (PST) In-Reply-To: References: From: Sebastian Pop Date: Sun, 22 Nov 2015 07:34:00 -0000 Message-ID: Subject: Re: [PATCH] GCC system.h and Graphite header order To: David Edelsohn Cc: Sebastian Pop , Richard Biener , GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg02600.txt.bz2 On Sat, Nov 21, 2015 at 4:03 PM, David Edelsohn wrote: > Graphite relies on the ISL library and includes multiple ISL headers. > The ISL headers refer to identifiers that are poisoned for use in GCC. > The source files for Graphite were organized to include the ISL > headers first, to avoid the identifier poisoning, which breaks some > platforms because GCC header features are disabled. > > This patch reorganizes the graphite*.c header file inclusion order to > list ISL header files near the end, just before the graphite header > files on which they rely. A new macro, USES_ISL, is defined, which > skips the relevant identifier poisoning, similar to logic for Flex and > Bison. > > This patch also removes early inclusion of stddef.h for ISL because it > now should be provided by GCC system.h > > This has been bootstrapped on powerpc-ibm-aix7.1.0.0 > > Okay for trunk? > > Thanks, David > > * system.h: Don't poison calloc and strdup if USES_ISL is defined. > * graphite-dependences.c: Define USES_ISL. Include ISL header files > after GCC header files and before graphite header files. > * graphite-dependences.c: Same. > * graphite-isl-ast-to-gimple.c: Same. > * graphite-optimize-isl.c: Same. > * graphite-poly.c: Same. > * graphite-scop-detection.c: Same. > * graphite-sese-to-poly.c: Same. > * graphite.c: Same. The patch looks good to me. Thanks David for fixing this. Sebastian