From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51905 invoked by alias); 30 Jun 2015 00:10:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 51896 invoked by uid 89); 30 Jun 2015 00:10:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f176.google.com Received: from mail-ie0-f176.google.com (HELO mail-ie0-f176.google.com) (209.85.223.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 30 Jun 2015 00:10:12 +0000 Received: by iecvh10 with SMTP id vh10so1640761iec.3 for ; Mon, 29 Jun 2015 17:10:10 -0700 (PDT) X-Received: by 10.107.137.210 with SMTP id t79mr20420682ioi.16.1435623009974; Mon, 29 Jun 2015 17:10:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.29.201 with HTTP; Mon, 29 Jun 2015 17:09:30 -0700 (PDT) In-Reply-To: <1435608255-10186-1-git-send-email-hiraditya@msn.com> References: <1435608255-10186-1-git-send-email-hiraditya@msn.com> From: Sebastian Pop Date: Tue, 30 Jun 2015 00:13:00 -0000 Message-ID: Subject: Re: [PATCH] Discard Scops for which entry==exit To: Aditya Kumar Cc: GCC Patches , Tobias Grosser Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg02129.txt.bz2 On Mon, Jun 29, 2015 at 3:04 PM, Aditya Kumar wrote: > In this patch we discard the scops where entry and exit are the same BB. > This is an effort to remove graphite-scop-detection.c:limit_scops. > Removing the limit_scops function introduces correctness regressions. > We are making relevant changes in incremental steps to fix those bugs, > and finally we intend to remove limit_scops. > > 2015-06-29 Aditya Kumar > Sebastian Pop > > * graphite-scop-detection.c (build_scops_1): Discard scops for which entry==exit Looks good to me. Let's wait on comments from Tobi before pushing this patch. Thanks, Sebastian > > > --- > gcc/graphite-scop-detection.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/gcc/graphite-scop-detection.c b/gcc/graphite-scop-detection.c > index e8ddecd..f57cc4a 100644 > --- a/gcc/graphite-scop-detection.c > +++ b/gcc/graphite-scop-detection.c > @@ -810,7 +810,14 @@ build_scops_1 (basic_block current, loop_p outermost_loop, > { > open_scop.exit = sinfo.exit; > gcc_assert (open_scop.exit); > - scops->safe_push (open_scop); > + if (open_scop.entry != open_scop.exit) > + scops->safe_push (open_scop); > + else > + { > + sinfo.difficult = true; > + sinfo.exits = false; > + sinfo.exit = NULL; > + } > } > > result.exit = sinfo.exit; > -- > 2.1.0.243.g30d45f7 >