From: Marcus Shawcroft <marcus.shawcroft@gmail.com>
To: Jiong Wang <jiong.wang@arm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [AArch64][1/2] Mark GOT related MEM rtx as const to help RTL loop IV
Date: Fri, 10 Jul 2015 12:10:00 -0000 [thread overview]
Message-ID: <CAFqB+Pw+7u0kQNZ=XK7UiLq2Yp6sOuOYgnpb=p8uWcD2g+E25A@mail.gmail.com> (raw)
In-Reply-To: <n99y4isb053.fsf@arm.com>
On 7 July 2015 at 13:33, Jiong Wang <jiong.wang@arm.com> wrote:
> 2015-07-06 Jiong Wang <jiong.wang@arm.com>
>
> gcc/
> * config/aarch64/aarch64.c (aarch64_load_symref_appropriately): Mark mem as
> READONLY and NOTRAP for PIC symbol.
>
> gcc/testsuite/
> * gcc.target/aarch64/got_mem_hoist.c: New test.
Looks, OK to me. Follow the guidance on the wiki here
https://gcc.gnu.org/wiki/TestCaseWriting when naming new test cases
and add _1 suffix. Otherwise OK.
/Marcus
prev parent reply other threads:[~2015-07-10 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 12:52 Jiong Wang
2015-07-07 12:54 ` [AArch64][2/2] Define TARGET_UNSPEC_MAY_TRAP_P for AArch64 Jiong Wang
2015-07-08 16:38 ` James Greenhalgh
2015-07-10 12:10 ` Marcus Shawcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqB+Pw+7u0kQNZ=XK7UiLq2Yp6sOuOYgnpb=p8uWcD2g+E25A@mail.gmail.com' \
--to=marcus.shawcroft@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jiong.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).