From: Marcus Shawcroft <marcus.shawcroft@gmail.com>
To: Kugan <kugan.vivekanandarajah@linaro.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook
Date: Fri, 02 May 2014 10:15:00 -0000 [thread overview]
Message-ID: <CAFqB+Pw99hKwU8qFhA1G+mxBEovC=dKn9RQT4Hni3-iCEb0p3Q@mail.gmail.com> (raw)
In-Reply-To: <CAFqB+Pz4iGG3rjdD14GvE-o7F2msdeM_G3ANFNf5NwPtdHtbag@mail.gmail.com>
On 2 May 2014 11:06, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote:
> Kugan, I've not looked at the respin in detail yet, but it has just
> occurred to me that the sequence used here to set FPCR is
> insufficient. The architecture reference manual requires that any
> write to FPCR must be syncrhronized by a context synchronization
> operation so we need to plant an ISB after the write. Both the write
> and ISB are likely to be expensive on some implementations so it would
> be good to ensure that both the write and the isb are scheduled
> independently. IIRC there si
Sorry, incomplete sentence. I had started to write that IIRC the same
issue did not apply to FPSCR in the ARM patch. I have doubled checked
and the FPSCR does not have the issue therefore the ARM patch is fine
in this respect.
/Marcus
next prev parent reply other threads:[~2014-05-02 10:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 12:00 Kugan
2014-04-28 10:03 ` Marcus Shawcroft
2014-04-28 11:06 ` Ramana Radhakrishnan
2014-04-29 3:03 ` Kugan
2014-05-02 9:08 ` Kugan
2014-05-02 11:58 ` Yufeng Zhang
2014-05-02 10:06 ` Marcus Shawcroft
2014-05-02 10:15 ` Marcus Shawcroft [this message]
2014-05-02 12:27 ` Kugan
2014-05-11 23:45 ` Kugan
2014-05-22 14:24 ` Marcus Shawcroft
2015-06-17 16:35 ` James Greenhalgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqB+Pw99hKwU8qFhA1G+mxBEovC=dKn9RQT4Hni3-iCEb0p3Q@mail.gmail.com' \
--to=marcus.shawcroft@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kugan.vivekanandarajah@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).