[PATCH][AARCH64]Use selected cpu's tuning when no tuning parameter is specified.

[PATCH][AARCH64]Use selected cpu's tuning when no tuning parameter is specified.

[Renlin Li]

[-- Attachment #1: Type: text/plain, Size: 1469 bytes --]

Hi all,

We have the following code in aarch64_override_options() function.

   /* The selected cpu may be an architecture, so lookup tuning by core 
ID.  */
   if (!selected_tune)
     selected_tune = &all_cores[selected_cpu->core];

However, the logic here is not right any more according to our current 
code. selected_cpu will never be an architecture at this point.

This patch will correct the behaviour and use selected_cpu's tuning 
directly if selected_tune is still not decided at this point.


We have the following consequence after the change.
Previously we have the following tuning settings with the following 
command line options:
-march=armv8-a --> selected_cpu = generic, aarch64_tune_params = 
cortexa53_tunings
Nothing specified and selected_cpu == generic --> aarch64_tune_params = 
cortexa53_tunings

After the change, we got something different:
-march=armv8-a --> selected_cpu = generic, aarch64_tune_params = 
generic_tunings
Nothing specified and selected_cpu == generic --> aarch64_tune_params = 
generic_tunings

All other configuration(-march, -mcpu, -mtune) combinations should be 
unaffected.


aarch64-none-elf has been built and tested on the model, no issue.

Is it Okay for trunk?


gcc/ChangeLog:

2014-11-27  Renlin Li  <Renlin.Li@arm.com>

     * config/aarch64/aarch64.c (aarch64_parse_cpu): Don't define 
selected_tune.
     (aarch64_override_options): Use selected_cpu's tuning.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 3.patch --]
[-- Type: text/x-patch; name=3.patch, Size: 804 bytes --]

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 1809513..0a8c303 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -6613,7 +6613,6 @@ aarch64_parse_cpu (void)
       if (strlen (cpu->name) == len && strncmp (cpu->name, str, len) == 0)
 	{
 	  selected_cpu = cpu;
-	  selected_tune = cpu;
 	  aarch64_isa_flags = selected_cpu->flags;
 
 	  if (ext != NULL)
@@ -6709,9 +6708,8 @@ aarch64_override_options (void)
 
   gcc_assert (selected_cpu);
 
-  /* The selected cpu may be an architecture, so lookup tuning by core ID.  */
   if (!selected_tune)
-    selected_tune = &all_cores[selected_cpu->core];
+    selected_tune = selected_cpu;
 
   aarch64_tune_flags = selected_tune->flags;
   aarch64_tune = selected_tune->core;

[PING] [PATCH][AARCH64]Use selected cpu's tuning when no tuning parameter is specified.

[Renlin Li]

On 27/11/14 11:27, Renlin Li wrote:
> Hi all,
>
> We have the following code in aarch64_override_options() function.
>
>   /* The selected cpu may be an architecture, so lookup tuning by core 
> ID.  */
>   if (!selected_tune)
>     selected_tune = &all_cores[selected_cpu->core];
>
> However, the logic here is not right any more according to our current 
> code. selected_cpu will never be an architecture at this point.
>
> This patch will correct the behaviour and use selected_cpu's tuning 
> directly if selected_tune is still not decided at this point.
>
>
> We have the following consequence after the change.
> Previously we have the following tuning settings with the following 
> command line options:
> -march=armv8-a --> selected_cpu = generic, aarch64_tune_params = 
> cortexa53_tunings
> Nothing specified and selected_cpu == generic --> aarch64_tune_params 
> = cortexa53_tunings
>
> After the change, we got something different:
> -march=armv8-a --> selected_cpu = generic, aarch64_tune_params = 
> generic_tunings
> Nothing specified and selected_cpu == generic --> aarch64_tune_params 
> = generic_tunings
>
> All other configuration(-march, -mcpu, -mtune) combinations should be 
> unaffected.
>
>
> aarch64-none-elf has been built and tested on the model, no issue.
>
> Is it Okay for trunk?
>
>
> gcc/ChangeLog:
>
> 2014-11-27  Renlin Li  <Renlin.Li@arm.com>
>
>     * config/aarch64/aarch64.c (aarch64_parse_cpu): Don't define 
> selected_tune.
>     (aarch64_override_options): Use selected_cpu's tuning.
>
>

PING~

Regards,
Renlin

Re: [PATCH][AARCH64]Use selected cpu's tuning when no tuning parameter is specified.

[Marcus Shawcroft]

On 27 November 2014 at 11:27, Renlin Li <renlin.li@arm.com> wrote:

> gcc/ChangeLog:
>
> 2014-11-27  Renlin Li  <Renlin.Li@arm.com>
>
>     * config/aarch64/aarch64.c (aarch64_parse_cpu): Don't define
> selected_tune.
>     (aarch64_override_options): Use selected_cpu's tuning.
>

OK and this is also broken in 4.9, could you prepare a backport please. /Marcus

[PATCH][AARCH64][4.9]Backport "Use selected cpu's tuning when no tuning parameter is specified."

[Renlin Li]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

On 04/12/14 10:27, Marcus Shawcroft wrote:
> On 27 November 2014 at 11:27, Renlin Li <renlin.li@arm.com> wrote:
>
>> gcc/ChangeLog:
>>
>> 2014-11-27  Renlin Li  <Renlin.Li@arm.com>
>>
>>      * config/aarch64/aarch64.c (aarch64_parse_cpu): Don't define
>> selected_tune.
>>      (aarch64_override_options): Use selected_cpu's tuning.
>>
> OK and this is also broken in 4.9, could you prepare a backport please. /Marcus
>

This is a backport patch of 
https://gcc.gnu.org/ml/gcc-patches/2014-12/msg00287.html

aarch64-none-elf has been built and tested on the model, no issue.
Okay for branch 4.9?

Regards,
Renlin Li


gcc/ChangeLog:

2014-12-10 Renlin Li <renlin.li@arm.com>

         * config/aarch64/aarch64.c (aarch64_parse_cpu): Remove 
selected_tune
         assignment as this will be done later.
         (aarch64_override_options): Use selected_cpu's tuning.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 3.patch --]
[-- Type: text/x-patch; name=3.patch, Size: 804 bytes --]

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 1809513..0a8c303 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -6613,7 +6613,6 @@ aarch64_parse_cpu (void)
       if (strlen (cpu->name) == len && strncmp (cpu->name, str, len) == 0)
 	{
 	  selected_cpu = cpu;
-	  selected_tune = cpu;
 	  aarch64_isa_flags = selected_cpu->flags;
 
 	  if (ext != NULL)
@@ -6709,9 +6708,8 @@ aarch64_override_options (void)
 
   gcc_assert (selected_cpu);
 
-  /* The selected cpu may be an architecture, so lookup tuning by core ID.  */
   if (!selected_tune)
-    selected_tune = &all_cores[selected_cpu->core];
+    selected_tune = selected_cpu;
 
   aarch64_tune_flags = selected_tune->flags;
   aarch64_tune = selected_tune->core;

Re: [PATCH][AARCH64][4.9]Backport "Use selected cpu's tuning when no tuning parameter is specified."

[Marcus Shawcroft]

On 10 December 2014 at 13:58, Renlin Li <renlin.li@arm.com> wrote:

> This is a backport patch of
> https://gcc.gnu.org/ml/gcc-patches/2014-12/msg00287.html
>
> aarch64-none-elf has been built and tested on the model, no issue.
> Okay for branch 4.9?
>
> Regards,
> Renlin Li
>
>
> gcc/ChangeLog:
>
> 2014-12-10 Renlin Li <renlin.li@arm.com>
>
>         * config/aarch64/aarch64.c (aarch64_parse_cpu): Remove selected_tune
>         assignment as this will be done later.
>         (aarch64_override_options): Use selected_cpu's tuning.

OK /Marcus