From: Marcus Shawcroft <marcus.shawcroft@gmail.com>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Marcus Shawcroft <marcus.shawcroft@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
James Greenhalgh <james.greenhalgh@arm.com>
Subject: Re: [PATCH][AArch64] Properly handle SHIFT ops and EXTEND in aarch64_rtx_mult_cost
Date: Thu, 30 Apr 2015 12:13:00 -0000 [thread overview]
Message-ID: <CAFqB+Py4O0DfDRKkmRqTBMtV3ErS7RoW=WMRQ7iH0tr+e3efVQ@mail.gmail.com> (raw)
In-Reply-To: <55352AD9.1030408@arm.com>
On 20 April 2015 at 17:35, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
> Hi all,
>
> The aarch64_rtx_mult_cost helper is supposed to handle multiplication costs
> as well as
> PLUS/MINUS operations combined with multiplication or shift operations. The
> shift
> operations may contain an extension. Currently we do not handle all these
> cases properly.
> We also don't handle other supported shift types besides ASHIFT.
>
> This patch addresses that by beefing up aarch64_rtx_mult_cost to handle
> extensions inside the shifts and handling the other kinds of supported
> shifts.
>
> Bootstrapped and tested on aarch64-linux.
>
> Ok for trunk?
>
> Thanks,
> Kyrill
>
> 2015-04-20 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> * config/aarch64/aarch64.c (aarch64_shift_p): New function.
> (aarch64_rtx_mult_cost): Update comment to reflect that it also handles
> combined arithmetic-shift ops. Properly handle all shift and extend
> operations that can occur in combination with PLUS/MINUS.
> Rename maybe_fma to compound_p.
> (aarch64_rtx_costs): Use aarch64_shift_p when costing compound
> arithmetic and shift operations.
+/* Return true iff CODE is a shift supported in combination
+ with arithmetic instructions. */
+static bool
+aarch64_shift_p (enum rtx_code code)
OK, but add the blank line between the function comment and the
function please. /Marcus
prev parent reply other threads:[~2015-04-30 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 16:35 Kyrill Tkachov
2015-04-30 12:13 ` Marcus Shawcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqB+Py4O0DfDRKkmRqTBMtV3ErS7RoW=WMRQ7iH0tr+e3efVQ@mail.gmail.com' \
--to=marcus.shawcroft@gmail.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=james.greenhalgh@arm.com \
--cc=kyrylo.tkachov@arm.com \
--cc=marcus.shawcroft@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).