From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20078 invoked by alias); 14 Mar 2013 08:37:30 -0000 Received: (qmail 19986 invoked by uid 22791); 14 Mar 2013 08:37:29 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Mar 2013 08:37:23 +0000 Received: by mail-ob0-f175.google.com with SMTP id uz6so1899700obc.6 for ; Thu, 14 Mar 2013 01:37:22 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.11.197 with SMTP id s5mr703650oeb.100.1363250242380; Thu, 14 Mar 2013 01:37:22 -0700 (PDT) Received: by 10.60.155.205 with HTTP; Thu, 14 Mar 2013 01:37:22 -0700 (PDT) In-Reply-To: <20130308093239.GO12913@tucnak.redhat.com> References: <20130307111536.GA12913@tucnak.redhat.com> <20130307164501.GI12913@tucnak.redhat.com> <5139A993.4010906@arm.com> <20130308093239.GO12913@tucnak.redhat.com> Date: Thu, 14 Mar 2013 08:37:00 -0000 Message-ID: Subject: Re: [PATCH] Fix -print-multi-os-directory for aarch64 From: Marcus Shawcroft To: Jakub Jelinek Cc: Marcus Shawcroft , Andrew Pinski , Paolo Bonzini , Alexandre Oliva , Matthias Klose , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-03/txt/msg00490.txt.bz2 On 8 March 2013 09:32, Jakub Jelinek wrote: > On Fri, Mar 08, 2013 at 09:04:19AM +0000, Marcus Shawcroft wrote: >> On 07/03/13 16:45, Jakub Jelinek wrote: >> >On Thu, Mar 07, 2013 at 08:29:06AM -0800, Andrew Pinski wrote: >> >>On Thu, Mar 7, 2013 at 3:15 AM, Jakub Jelinek wrote: >> >>>AFAIK aarch64 libraries are supposed to go into /usr/lib64 etc. >> >>>directories similarly to x86-64 etc., but as aarch64 isn't a true >> >>>multilib target (having two different backends for 32-bit vs. 64-bit code), >> >>>currently gcc -print-multi-os-directory prints . instead of ../lib64. >> >> >> >>I think glibc is broken also. So after this change, the build using >> >>the released 2.17 and this new gcc breaks. >> > >> >Then glibc will need patching too. Distros using multiarch aren't affected >> >by this, others IMHO will want it in */lib64 and for aarch64 IMHO it isn't >> >still too late for that change. >> >> Hi, Moving from /lib to /lib64 will affect binutils 2.23 (ld) and >> glibc 2.17. This seems to me to be a rather disruptive change this >> late in the day. > > Yes, it does affect them, on the binutils side it would be about > setting LIBPATH_SUFFIX=64 in ld/emulparams/aarch64linux.sh when appropriate > (grep LIBPATH_SUFFIX=64 ld/emulparams/*.sh to see what other targets do), > on the glibc side for other targets sysdeps/gnu/configure.in > is where libc_cv_slibdir and libc_cv_libdir are tweaked. > Note, this change doesn't affect multiarch, so Debian/Ubuntu is unaffected, > for others there can be an easy workaround for transitional period > (just add */lib64 -> */lib symlinks (or vice versa)). > The point of using */lib64 is that it is consistent with how most other > important 64-bit architectures are handled (x86_64, ppc64, s390x, sparc64, > mips64) and that even if you don't expect coexistence of 32-bit arm and > 64-bit aarch64 libraries on the same filesystem right now, using */lib64 > allows that in the future. Even if some distros use lib64 -> lib or vice > versa symlinks for some time if they choose so, if there is agreement to go > with lib64 path suffixes, it means packages that need to know this can be > changed, rather than adding horrible hacks to see what library suffixes > should be used. My concern about the disruption associated with this change aside, I agree that the change needs to happen in order to avoid long term pain. I see no objections on this thread or the related thread over at glibc-ports, so go ahead and commit the patch. /Marcus