From: Marcus Shawcroft <marcus.shawcroft@gmail.com>
To: Ramana Radhakrishnan <ramana.radhakrishnan@foss.arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch AArch64] Use default_elf_asm_named_section instead of special cased hook
Date: Fri, 02 Oct 2015 13:05:00 -0000 [thread overview]
Message-ID: <CAFqB+PytNUoHV5nswBayzn360-RfTVix5D8Hi87h9JPTST2psw@mail.gmail.com> (raw)
In-Reply-To: <560E8016.2040701@foss.arm.com>
On 2 October 2015 at 14:01, Ramana Radhakrishnan
<ramana.radhakrishnan@foss.arm.com> wrote:
>>> #undef TARGET_ASM_NAMED_SECTION
>>> -#define TARGET_ASM_NAMED_SECTION aarch64_elf_asm_named_section
>>> +#define TARGET_ASM_NAMED_SECTION default_elf_asm_named_section
>>
>> Isn't it sufficient to simply remove the #define completely and rely
>> on the default from elfos.h?
>
> Doh ! you're right - Yeah should be coming in from config/elfos.h given that we don't support anything other than elf in the aarch64 port.
>
> Ok to commit without that hunk ?
Yes. /Marcus
next prev parent reply other threads:[~2015-10-02 13:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 10:08 Ramana Radhakrishnan
2015-10-02 12:46 ` Marcus Shawcroft
2015-10-02 13:01 ` Ramana Radhakrishnan
2015-10-02 13:05 ` Marcus Shawcroft [this message]
2015-10-02 16:40 ` Christophe Lyon
2015-10-02 16:53 ` Ramana Radhakrishnan
2016-06-22 13:50 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFqB+PytNUoHV5nswBayzn360-RfTVix5D8Hi87h9JPTST2psw@mail.gmail.com \
--to=marcus.shawcroft@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ramana.radhakrishnan@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).