From: Marcus Shawcroft <marcus.shawcroft@gmail.com>
To: Wilco Dijkstra <wdijkstr@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][AArch64] Make aarch64_min_divisions_for_recip_mul configurable
Date: Fri, 01 May 2015 07:44:00 -0000 [thread overview]
Message-ID: <CAFqB+PzAUb=bFjhRpQwD9WaFfnL-jVuvUaRqig=khKP2oeffPQ@mail.gmail.com> (raw)
In-Reply-To: <000401d080f0$16a78c90$43f6a5b0$@com>
On 27 April 2015 at 14:43, Wilco Dijkstra <wdijkstr@arm.com> wrote:
>> static unsigned int
>> -aarch64_min_divisions_for_recip_mul (enum machine_mode mode ATTRIBUTE_UNUSED)
>> +aarch64_min_divisions_for_recip_mul (enum machine_mode mode)
>> {
>> - return 2;
>> + if (GET_MODE_UNIT_SIZE (mode) == 4)
>> + return aarch64_tune_params->min_div_recip_mul_sf;
>> + return aarch64_tune_params->min_div_recip_mul_df;
This should be expressed directly as mode == SFmode (or DFmode) rather
than the indirect approach of first computing the size first.
/Marcus
next prev parent reply other threads:[~2015-05-01 7:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 13:43 Wilco Dijkstra
2015-05-01 7:44 ` Marcus Shawcroft [this message]
2015-05-01 11:26 ` Wilco Dijkstra
2015-05-01 12:17 ` Marcus Shawcroft
2015-05-01 13:12 ` Wilco Dijkstra
2015-05-01 13:20 ` Kyrill Tkachov
-- strict thread matches above, loose matches on Subject: below --
2015-03-03 18:06 Wilco Dijkstra
2015-03-03 18:34 ` Andrew Pinski
2015-03-03 19:08 ` Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqB+PzAUb=bFjhRpQwD9WaFfnL-jVuvUaRqig=khKP2oeffPQ@mail.gmail.com' \
--to=marcus.shawcroft@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=wdijkstr@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).