From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-396570-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 22549 invoked by alias); 1 May 2015 07:44:55 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 22530 invoked by uid 89); 1 May 2015 07:44:54 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-wg0-f44.google.com
Received: from mail-wg0-f44.google.com (HELO mail-wg0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 01 May 2015 07:44:53 +0000
Received: by wgin8 with SMTP id n8so84569201wgi.0        for <gcc-patches@gcc.gnu.org>; Fri, 01 May 2015 00:44:50 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.180.94.39 with SMTP id cz7mr9802364wib.66.1430466290866; Fri, 01 May 2015 00:44:50 -0700 (PDT)
Received: by 10.28.104.138 with HTTP; Fri, 1 May 2015 00:44:50 -0700 (PDT)
In-Reply-To: <000401d080f0$16a78c90$43f6a5b0$@com>
References: <000401d080f0$16a78c90$43f6a5b0$@com>
Date: Fri, 01 May 2015 07:44:00 -0000
Message-ID: <CAFqB+PzAUb=bFjhRpQwD9WaFfnL-jVuvUaRqig=khKP2oeffPQ@mail.gmail.com>
Subject: Re: [PATCH][AArch64] Make aarch64_min_divisions_for_recip_mul configurable
From: Marcus Shawcroft <marcus.shawcroft@gmail.com>
To: Wilco Dijkstra <wdijkstr@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-05/txt/msg00008.txt.bz2

On 27 April 2015 at 14:43, Wilco Dijkstra <wdijkstr@arm.com> wrote:

>>  static unsigned int
>> -aarch64_min_divisions_for_recip_mul (enum machine_mode mode ATTRIBUTE_UNUSED)
>> +aarch64_min_divisions_for_recip_mul (enum machine_mode mode)
>>  {
>> -  return 2;
>> +  if (GET_MODE_UNIT_SIZE (mode) == 4)
>> +    return aarch64_tune_params->min_div_recip_mul_sf;
>> +  return aarch64_tune_params->min_div_recip_mul_df;

This should be expressed directly as mode == SFmode (or DFmode) rather
than the indirect approach of first computing the size first.

/Marcus