From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10827 invoked by alias); 8 Jan 2013 09:33:27 -0000 Received: (qmail 10816 invoked by uid 22791); 8 Jan 2013 09:33:26 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-ob0-f173.google.com (HELO mail-ob0-f173.google.com) (209.85.214.173) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Jan 2013 09:33:23 +0000 Received: by mail-ob0-f173.google.com with SMTP id xn12so154744obc.32 for ; Tue, 08 Jan 2013 01:33:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.48.69 with SMTP id j5mr4723580obn.17.1357637602443; Tue, 08 Jan 2013 01:33:22 -0800 (PST) Received: by 10.60.134.210 with HTTP; Tue, 8 Jan 2013 01:33:22 -0800 (PST) In-Reply-To: References: Date: Tue, 08 Jan 2013 09:33:00 -0000 Message-ID: Subject: Re: [Patch, AARCH64] Define REVERSIBLE_CC_MODE From: Marcus Shawcroft To: "Hurugalawadi, Naveen" Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00395.txt.bz2 On 8 January 2013 05:09, Hurugalawadi, Naveen wrote: > Hi, > > AARCH64 back-end defines REVERSE_CONDITION but not REVERSIBLE_CC_MODE. > REVERSE_CONDITION is used only in case REVERSIBLE_CC_MODE (mode) is > nonzero. > > Please find attached the patch that defines REVERSIBLE_CC_MODE for > aarch64 back-end. Please review the patch and let me know if there should be any > modifications? > > Build and tested on aarch64-thunder-elf (using Cavium's internal > simulator). > > Thanks, > Naveen.H.S > > 2013-01-08 Naveen H.S > > * config/aarch64/aarch64.h (REVERSIBLE_CC_MODE): Define. +/* A C expression whose value is one if it is always safe to reverse a + comparison whose mode is MODE. If `SELECT_CC_MODE' can ever return + MODE for a floating-point inequality comparison, then + `REVERSIBLE_CC_MODE (MODE)' must be zero. + You need not define this macro if it would always returns zero or if the + floating-point format is anything other than `IEEE_FLOAT_FORMAT'. */ +#define REVERSIBLE_CC_MODE(MODE) 1 + Given the comment about SELECT_CC_MODE and the implementation of aarch64_select_cc_mode this definition of REVERSIBLE_CC_MODE looks broken to me. /Marcus