From: Jim Wilson <jimw@sifive.com>
To: Craig Blackmore <craig.blackmore@embecosm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Ofer Shinaar <Ofer.Shinaar@wdc.com>,
Nidal Faour <Nidal.Faour@wdc.com>,
Kito Cheng <kito.cheng@gmail.com>, Jeff Law <law@redhat.com>
Subject: Re: [PATCH v2 2/2] sched-deps.c: Avoid replacing address if it increases address cost
Date: Thu, 31 Oct 2019 02:00:00 -0000 [thread overview]
Message-ID: <CAFyWVaYwN_XmbaNVNNnHNPkMN2DRRQswoExWpiWZqZ_A_pWt4g@mail.gmail.com> (raw)
In-Reply-To: <1572025151-22783-3-git-send-email-craig.blackmore@embecosm.com>
On Fri, Oct 25, 2019 at 10:40 AM Craig Blackmore
<craig.blackmore@embecosm.com> wrote:
> The sched2 pass undoes some of the addresses generated by the RISC-V
> shorten_memrefs code size optimization (patch 1/2) and consequently increases
> code size. This patch prevents sched-deps.c from changing an address if it is
> expected to increase address cost.
This should be rewritten as a target hook, and then we can define the
hook to do what we want for RISC-V. It isn't OK to make this change
for other targets without testing them. If the default hook does
nothing, then other targets won't be affected.
Jim
next prev parent reply other threads:[~2019-10-31 0:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 16:19 [PATCH] RISC-V: Allow more load/stores to be compressed Craig Blackmore
2019-09-18 10:01 ` Kito Cheng
2019-10-25 17:40 ` [PATCH v2 0/2] " Craig Blackmore
2019-10-25 17:40 ` [PATCH v2 1/2] RISC-V: Add shorten_memrefs pass Craig Blackmore
2019-10-26 18:25 ` Jeff Law
2019-10-26 19:16 ` Oleg Endo
2019-10-26 20:04 ` Jeff Law
2019-10-26 20:02 ` Andrew Waterman
2019-10-26 20:16 ` Jeff Law
2019-10-27 7:13 ` Oleg Endo
2019-10-31 0:00 ` Jim Wilson
2019-10-31 9:42 ` Nidal Faour
2019-10-31 10:42 ` Andrew Waterman
2019-10-31 15:57 ` Ofer Shinaar
2019-12-10 18:28 ` Craig Blackmore
2020-02-19 11:40 ` Craig Blackmore
2020-04-08 16:04 ` Jim Wilson
2020-04-27 17:08 ` Craig Blackmore
2020-05-12 22:33 ` Jim Wilson
2020-05-13 17:51 ` Craig Blackmore
2019-10-31 0:03 ` Jim Wilson
2019-10-25 17:57 ` [PATCH v2 2/2] sched-deps.c: Avoid replacing address if it increases address cost Craig Blackmore
2019-10-31 2:00 ` Jim Wilson [this message]
2019-12-10 18:29 ` Craig Blackmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyWVaYwN_XmbaNVNNnHNPkMN2DRRQswoExWpiWZqZ_A_pWt4g@mail.gmail.com \
--to=jimw@sifive.com \
--cc=Nidal.Faour@wdc.com \
--cc=Ofer.Shinaar@wdc.com \
--cc=craig.blackmore@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kito.cheng@gmail.com \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).