From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 2F6603857C44 for ; Thu, 6 May 2021 01:23:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2F6603857C44 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jimw@sifive.com Received: by mail-ed1-x531.google.com with SMTP id i24so4183652edy.8 for ; Wed, 05 May 2021 18:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VtsETEbi6aztZWKKVMXJh9GaqPcR0p1/Kjh0/+17Kyc=; b=OSnah+yITjUpifbEH44eRQX9CpHF/7B0M6cUPv8ef0PweGz09QsNkBp61MMtIplEUb tipWS3XzVmqRadEecbJySvnsgKPshhJhacI6jn74cJ5+mFOUA2OMDdSS1ODXZGLkXHZx jFd9Wn93RaZJtAPtOjxMJKVDWN8+BZUr+PWIKtSaRuEQ5ala6t8eu374sNpNWpJBboEZ MQGBaIifKVFTwP4N6pLwmA6/KK7CYDrfF99E2AMHK9jNm8LX8v1tv0szn4pgn04D1/ng Jh9MzH44eFUjGS9aJ6ZAEjMucOxQAr5GTeYHHvRXqKXTy1DWJIDbEWoy9PDh7psJSLmg /R0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VtsETEbi6aztZWKKVMXJh9GaqPcR0p1/Kjh0/+17Kyc=; b=Rqw9cJGG2xzTZ7MKywW4V9Mi/n9qziglWjtsJKGEG3cAO2ZHi1mGVlobj/xN7c5YUv vSozoy2AOVj1x9quZTgG5LVwY5vF0AxvBsduZYxuCNy+Q9lagk661lvAxKe45MZe+KJ/ PgnK+KUSg/L9h9SuHYDMnk9/OT8DeZAKHTiBCxrBNkLnh+aIWsba7kPNRULcY7IG0I7K bE9BdIbF2A4C2yDjF+wT3PI3rGuAw9cjRryi3Pph3JxDagBVcjuTBU+xs5yVUETwAxws dyQ+m1GhhloqJQJLDPl9s0sLXu/olUSjwYnXAc571ZVkU99CydT7rsVvyMX4BuhG8mkJ qNsA== X-Gm-Message-State: AOAM530pPWhKDDzG4veAr4//ucJ6CXwv7BHdgdDsAB0SP8jh9ZqyQdoV PqZkCy3SduM9dp/kiAT+8YD+ABGfjS5SyA/hYNj5IA== X-Google-Smtp-Source: ABdhPJxGHmkcD/5Na6M/NNuM6GP3J/ZrfYcp4naTd/h4WTIvnVwVxFPwO4e9C+ZUZR9/Hos6Y6LTiIGs5SdETp102qw= X-Received: by 2002:a05:6402:204c:: with SMTP id bc12mr1977698edb.35.1620264196289; Wed, 05 May 2021 18:23:16 -0700 (PDT) MIME-Version: 1.0 References: <20210505192341.2069742-1-cmuellner@gcc.gnu.org> In-Reply-To: <20210505192341.2069742-1-cmuellner@gcc.gnu.org> From: Jim Wilson Date: Wed, 5 May 2021 18:23:05 -0700 Message-ID: Subject: Re: [PATCH] RISC-V: Generate helpers for cbranch4 To: Christoph Muellner Cc: GCC Patches , Kito Cheng X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 01:23:18 -0000 On Wed, May 5, 2021 at 12:23 PM Christoph Muellner wrote: > gcc/ > PR 100266 > * config/rsicv/riscv.c (riscv_block_move_loop): Simplify. > * config/rsicv/riscv.md (cbranch4): Generate helpers. > OK. Committed. Though I had to fix the ChangeLog entry. It was indented by spaces instead of tabs. The PR line is missing the component (target). riscv is misspelled twice as rsicv. And it doesn't mention the stack_protect_test change. The gcc commit hooks complained about most of this stuff. It seems fairly good at finding minor ChangeLog issues. Jim