From: Jim Wilson <jimw@sifive.com>
To: Geng Qi <gengqi@linux.alibaba.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
cooper <cooper.qu@linux.alibaba.com>
Subject: Re: [PATCH] RISC-V: Pattern name fix mulm3_highpart -> smulm3_highpart.
Date: Tue, 28 Sep 2021 16:44:01 -0700 [thread overview]
Message-ID: <CAFyWVabNV3+YMp8xbRgWFof1pEdyBkQL4cfCxMp=HF30WjJGmA@mail.gmail.com> (raw)
In-Reply-To: <20210927113745.171-1-gengqi@linux.alibaba.com>
On Mon, Sep 27, 2021 at 4:38 AM Geng Qi via Gcc-patches <
gcc-patches@gcc.gnu.org> wrote:
> gcc/ChangeLog:
> * config/riscv/riscv.md
> (<u>muldi3_highpart): Rename to <su>muldi3_highpart.
> (<u>mulditi3): Emit <su>muldi3_highpart.
> (<u>mulsi3_highpart): Rename to <su>mulsi3_highpart.
> (<u>mulsidi3): Emit <su>mulsi3_highpart.
>
This doesn't build on top of tree sources. It is missing the
mulv<mode>3_highpart change I mentioned in the riscv-gcc review. Also, I
prefer that the order of the changelog entries match the order of hunks in
the patch, it is easier to review that way. Otherwise, the patch is OK and
I committed it with minor changes. Since I changed it, I need to send the
patch I did actually commit.
Jim
next prev parent reply other threads:[~2021-09-28 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 11:37 Geng Qi
2021-09-28 23:44 ` Jim Wilson [this message]
2021-09-28 23:48 ` [PATCH] RISC-V: Pattern name fix mul*3_highpart -> smul*3_highpart Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFyWVabNV3+YMp8xbRgWFof1pEdyBkQL4cfCxMp=HF30WjJGmA@mail.gmail.com' \
--to=jimw@sifive.com \
--cc=cooper.qu@linux.alibaba.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gengqi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).