From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id C03D93858D35 for ; Tue, 28 Sep 2021 23:44:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C03D93858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-lf1-x134.google.com with SMTP id u18so2879716lfd.12 for ; Tue, 28 Sep 2021 16:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MuSsr1QdiiT5+TTuFt9ggbUD6rqB/NpN8ji0kn5jaDs=; b=jbVwDB9e4lvwfP1qwQzgEgvRQ/ubZHLDOKznvHDp0CGIAdHJUcFPvRz9bBql2Li2zi yOH5MCAtNRw5FbPogKE2KGUopOlcHTT+7hUviCRlFpRaY4b7yHGVGsd8JWNpSrLNXOvA UuFzI0xo6lUkkhc6r+3l9v5B74aBIavsxSVtGyHrWpSaSQw6Aj4XkpmisoVqbxLIvnpg D1A5+g3RK8LmzpwLenuk6L+EKcfMmC/wH6eUxfI/ni+iZi0YP29gct1plJ6jnUu70pI7 oHIiHguw/TaCAlyZ72TGDYChtdUJd7XXeut7jb0IheNBYDX7Mpls0hXuPYvxNVOyrIOm FfZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MuSsr1QdiiT5+TTuFt9ggbUD6rqB/NpN8ji0kn5jaDs=; b=2YnQQxAoo0MhMzhiDWLicWQw/cNtOykLAcfGueMgJUlscJNi8VUv2gLdEs94KSyYvo FFCpPxoKpirxFVsIyOLETXBnPreyt4u4EOBvscllsvsU2DLXmNswGvY5IuiCjRIaxZjH yFiA+A/k52uxdV6aTjqSntooH4mjq0/JYQhdbqCkP7qtqwtpFKqiOwX+eEmGzsLTtOI3 GY+CsPcJmffc1McN1bsRtnswfbmfLBEgKZHTdrW64NcysJRdOmlY7sO5R1vSR781Uch0 vjH3Fl0fco3haoAXZNW2Esy7iIOr4vrisWHBmvbPXzCueQHoKxgOSnezbFfKVWDExuh4 BiGw== X-Gm-Message-State: AOAM531YmbWyXJwFEKToex6CEac2lKHIdtSFwn5xy21vj7yiY7WmrHJi TSVismfyKNO8asJYfhMFsMWUlraK+cyAamXLmMrvBTJFBN8= X-Google-Smtp-Source: ABdhPJw0HXDabmEbatd46cNxx2/yfoObjm0pd0AcCoGXEkIZWrkXjK2QgE/SIIiuKXMKT09PYfwJGgSpVql2rFS0Xpg= X-Received: by 2002:a05:6512:32c8:: with SMTP id f8mr8382178lfg.683.1632872652501; Tue, 28 Sep 2021 16:44:12 -0700 (PDT) MIME-Version: 1.0 References: <20210927113745.171-1-gengqi@linux.alibaba.com> In-Reply-To: <20210927113745.171-1-gengqi@linux.alibaba.com> From: Jim Wilson Date: Tue, 28 Sep 2021 16:44:01 -0700 Message-ID: Subject: Re: [PATCH] RISC-V: Pattern name fix mulm3_highpart -> smulm3_highpart. To: Geng Qi Cc: GCC Patches , cooper X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2021 23:44:15 -0000 On Mon, Sep 27, 2021 at 4:38 AM Geng Qi via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > gcc/ChangeLog: > * config/riscv/riscv.md > (muldi3_highpart): Rename to muldi3_highpart. > (mulditi3): Emit muldi3_highpart. > (mulsi3_highpart): Rename to mulsi3_highpart. > (mulsidi3): Emit mulsi3_highpart. > This doesn't build on top of tree sources. It is missing the mulv3_highpart change I mentioned in the riscv-gcc review. Also, I prefer that the order of the changelog entries match the order of hunks in the patch, it is easier to review that way. Otherwise, the patch is OK and I committed it with minor changes. Since I changed it, I need to send the patch I did actually commit. Jim