[PATCH] doc/options.texi: Fix the discription of 'Negative'.

[PATCH] doc/options.texi: Fix the discription of 'Negative'.

[Geng Qi]

gcc/ChangeLog:
	* doc/options.texi (Negative): Fix the discription so that it matches
	the code implementation of prune_options().
---
 gcc/doc/options.texi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/doc/options.texi b/gcc/doc/options.texi
index 2057629..37386ca 100644
--- a/gcc/doc/options.texi
+++ b/gcc/doc/options.texi
@@ -223,8 +223,8 @@ propagate through the @code{Negative} property of the option to be
 turned off.  The driver will prune options, removing those that are
 turned off by some later option.  This pruning is not done for options
 with @code{Joined} or @code{JoinedOrMissing} properties, unless the
-options have either @code{RejectNegative} property or the @code{Negative}
-property mentions an option other than itself.
+options have both @code{RejectNegative} property and the @code{Negative}
+property mentions itself.
 
 As a consequence, if you have a group of mutually-exclusive
 options, their @code{Negative} properties should form a circular chain.
-- 
2.7.4

Re: [PATCH] doc/options.texi: Fix the discription of 'Negative'.

[Martin Sebor]

On 4/28/21 3:24 AM, Geng Qi via Gcc-patches wrote:
> gcc/ChangeLog:
> 	* doc/options.texi (Negative): Fix the discription so that it matches
> 	the code implementation of prune_options().
> ---
>   gcc/doc/options.texi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gcc/doc/options.texi b/gcc/doc/options.texi
> index 2057629..37386ca 100644
> --- a/gcc/doc/options.texi
> +++ b/gcc/doc/options.texi
> @@ -223,8 +223,8 @@ propagate through the @code{Negative} property of the option to be
>   turned off.  The driver will prune options, removing those that are
>   turned off by some later option.  This pruning is not done for options
>   with @code{Joined} or @code{JoinedOrMissing} properties, unless the
> -options have either @code{RejectNegative} property or the @code{Negative}
> -property mentions an option other than itself.
> +options have both @code{RejectNegative} property and the @code{Negative}
> +property mentions itself.

I don't know how it works so I can't comment on the correctness
of the change but while making an adjustment to the text can you
please also add the missing article before RejectNegative?

   ...have both <ins>the</ins> @code{RejectNegative} property and
   the @code{Negative} > +property mentions itself.

Thanks
Martin

>   
>   As a consequence, if you have a group of mutually-exclusive
>   options, their @code{Negative} properties should form a circular chain.
> 

Re: [PATCH] doc/options.texi: Fix the discription of 'Negative'.

[Jim Wilson]

On Wed, Apr 28, 2021 at 2:25 AM Geng Qi via Gcc-patches <
gcc-patches@gcc.gnu.org> wrote:

> gcc/ChangeLog:
>         * doc/options.texi (Negative): Fix the discription so that it
> matches
>         the code implementation of prune_options().
>

This matches my testing as mentioned in another thread, so I am approving
this and committed it, with the missing article added as Martin mentioned.

Jim