From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27621 invoked by alias); 8 Jan 2015 19:44:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27608 invoked by uid 89); 8 Jan 2015 19:44:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-qc0-f181.google.com Received: from mail-qc0-f181.google.com (HELO mail-qc0-f181.google.com) (209.85.216.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 08 Jan 2015 19:44:14 +0000 Received: by mail-qc0-f181.google.com with SMTP id m20so4177826qcx.12 for ; Thu, 08 Jan 2015 11:44:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=3cAMJn+8bstnJNGzPBsODFIBeQYXaaItPJwvxpKV+I0=; b=cAGI14qoNmvU22+k7ojWrYgjolKsHpWcf48fRzEsmL1fJzFKTMPYcYdBU+jtTh/RwL kUPxcVduq3vKh6eZiQ/bFP5dh//Mei5iHwGv7NoBIpYwUXPCC3AoW8tRw2kjktklweog FvXTPvDe8NDiNNPM8D5miCRnbR4pyJOYjP4sxel61fyBn4zLVwL6sRcPk3KbaxkgI0Dk ljEsCn45zWs947j87bENDTnjaFe61uAi/qXFYIlMP8ngH/3lbwnp3Pv9ScMv9EHkoLtW lZdJqdWqTuEqYKNM1UhOCwOMSvMw1zh+lth5PWdS7RH49PNbXSi+3EOGoE/9TjjS2rEr +wNw== X-Gm-Message-State: ALoCoQnl0DPVQ2amIrbr7T5SyTaRO5iY43Mz3WWuNV97DW3uuWaArqInA8dDdo0/ec/t30VWe2mr MIME-Version: 1.0 X-Received: by 10.140.89.18 with SMTP id u18mr18114341qgd.20.1420746252016; Thu, 08 Jan 2015 11:44:12 -0800 (PST) Received: by 10.96.254.231 with HTTP; Thu, 8 Jan 2015 11:44:11 -0800 (PST) In-Reply-To: <20150107123919.GC3360@redhat.com> References: <20150107123919.GC3360@redhat.com> Date: Thu, 08 Jan 2015 19:44:00 -0000 Message-ID: Subject: Re: [Patch, libstdc++/64239] Use std::swap instead of swap in regex From: Tim Shen To: Jonathan Wakely Cc: "libstdc++" , gcc-patches Content-Type: multipart/mixed; boundary=001a11c11e46ab31ef050c294375 X-SW-Source: 2015-01/txt/msg00407.txt.bz2 --001a11c11e46ab31ef050c294375 Content-Type: text/plain; charset=UTF-8 Content-length: 419 On Wed, Jan 7, 2015 at 4:39 AM, Jonathan Wakely wrote: > No blank line here in the ChangeLog. Done. > This is swapping iterators, which can be user-defined types, so it > should support finding a swap function by ADL, i.e. Done. > Also, there should be a new test, since apparently we don't have any > test that tries to call match_results::swap(match_results&). Done. -- Regards, Tim Shen --001a11c11e46ab31ef050c294375 Content-Type: text/plain; charset=US-ASCII; name="a.diff" Content-Disposition: attachment; filename="a.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i4ojmrln0 Content-length: 3636 Y29tbWl0IDkwMTE4NzA0ZGU2MjE0ZDlhOWNlNWQ4MmZlYThkMzY0ZDc1OGJj NjAKQXV0aG9yOiB0aW1zaGVuIDx0aW1zaGVuQGdvb2dsZS5jb20+CkRhdGU6 ICAgVHVlIEphbiA2IDE5OjMwOjI3IDIwMTUgLTA4MDAKCiAgICAJUFIgbGli c3RkYysrLzY0MjM5CiAgICAJKiBpbmNsdWRlL2JpdHMvcmVnZXguaCAobWF0 Y2hfcmVzdWx0czw+Ojpzd2FwKTogVXNlIHN0ZDo6c3dhcAogICAgCWluc3Rl YWQgb2Ygc3dhcC4KICAgIAkqIGluY2x1ZGUvYml0cy9yZWdleF9jb21waWxl ci50Y2MgKF9Db21waWxlcjw+OjpfTV9xdWFudGlmaWVyKToKICAgIAlMaWtl d2lzZS4KICAgIAkqIHRlc3RzdWl0ZS8yOF9yZWdleC9tYXRjaF9yZXN1bHRz L3N3YXAuY2M6IE5ldyB0ZXN0Y2FzZS4KCmRpZmYgLS1naXQgYS9saWJzdGRj KystdjMvaW5jbHVkZS9iaXRzL3JlZ2V4LmggYi9saWJzdGRjKystdjMvaW5j bHVkZS9iaXRzL3JlZ2V4LmgKaW5kZXggOWI3ZWQ4Yy4uNTJjMjM4NCAxMDA2 NDQKLS0tIGEvbGlic3RkYysrLXYzL2luY2x1ZGUvYml0cy9yZWdleC5oCisr KyBiL2xpYnN0ZGMrKy12My9pbmNsdWRlL2JpdHMvcmVnZXguaApAQCAtMTg2 Myw2ICsxODYzLDcgQEAgX0dMSUJDWFhfQkVHSU5fTkFNRVNQQUNFX0NYWDEx CiAgICAgICB2b2lkCiAgICAgICBzd2FwKG1hdGNoX3Jlc3VsdHMmIF9fdGhh dCkKICAgICAgIHsKKwl1c2luZyBzdGQ6OnN3YXA7CiAJX0Jhc2VfdHlwZTo6 c3dhcChfX3RoYXQpOwogCXN3YXAoX01fYmVnaW4sIF9fdGhhdC5fTV9iZWdp bik7CiAgICAgICB9CmRpZmYgLS1naXQgYS9saWJzdGRjKystdjMvaW5jbHVk ZS9iaXRzL3JlZ2V4X2NvbXBpbGVyLnRjYyBiL2xpYnN0ZGMrKy12My9pbmNs dWRlL2JpdHMvcmVnZXhfY29tcGlsZXIudGNjCmluZGV4IDU3YmFmYTMuLjMz ZDcxMTggMTAwNjQ0Ci0tLSBhL2xpYnN0ZGMrKy12My9pbmNsdWRlL2JpdHMv cmVnZXhfY29tcGlsZXIudGNjCisrKyBiL2xpYnN0ZGMrKy12My9pbmNsdWRl L2JpdHMvcmVnZXhfY29tcGlsZXIudGNjCkBAIC0yNzYsNyArMjc2LDcgQEAg X0dMSUJDWFhfQkVHSU5fTkFNRVNQQUNFX1ZFUlNJT04KIAkJewogCQkgIGF1 dG8mIF9fdG1wID0gKCpfTV9uZmEpW19fc3RhY2sudG9wKCldOwogCQkgIF9f c3RhY2sucG9wKCk7Ci0JCSAgc3dhcChfX3RtcC5fTV9uZXh0LCBfX3RtcC5f TV9hbHQpOworCQkgIHN0ZDo6c3dhcChfX3RtcC5fTV9uZXh0LCBfX3RtcC5f TV9hbHQpOwogCQl9CiAJICAgIH0KIAkgIF9NX3N0YWNrLnB1c2goX19lKTsK ZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjhfcmVnZXgv bWF0Y2hfcmVzdWx0cy9zd2FwLmNjIGIvbGlic3RkYysrLXYzL3Rlc3RzdWl0 ZS8yOF9yZWdleC9tYXRjaF9yZXN1bHRzL3N3YXAuY2MKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMTgyNDhjMQotLS0gL2Rldi9udWxs CisrKyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjhfcmVnZXgvbWF0Y2hf cmVzdWx0cy9zd2FwLmNjCkBAIC0wLDAgKzEsNDMgQEAKKy8vIHsgZGctb3B0 aW9ucyAiLXN0ZD1nbnUrKzExIiB9CisKKy8vCisvLyBDb3B5cmlnaHQgKEMp IDIwMTUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisvLworLy8g VGhpcyBmaWxlIGlzIHBhcnQgb2YgdGhlIEdOVSBJU08gQysrIExpYnJhcnku ICBUaGlzIGxpYnJhcnkgaXMgZnJlZQorLy8gc29mdHdhcmU7IHlvdSBjYW4g cmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkgaXQgdW5kZXIgdGhlCisv LyB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMg cHVibGlzaGVkIGJ5IHRoZQorLy8gRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9u OyBlaXRoZXIgdmVyc2lvbiAzLCBvciAoYXQgeW91ciBvcHRpb24pCisvLyBh bnkgbGF0ZXIgdmVyc2lvbi4KKy8vCisvLyBUaGlzIGxpYnJhcnkgaXMgZGlz dHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwK Ky8vIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRo ZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisvLyBNRVJDSEFOVEFCSUxJVFkgb3Ig RklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCisv LyBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxz LgorLy8KKy8vIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2Yg dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFsb25nCisvLyB3aXRo IHRoaXMgbGlicmFyeTsgc2VlIHRoZSBmaWxlIENPUFlJTkczLiAgSWYgbm90 IHNlZQorLy8gPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+LgorCisj aW5jbHVkZSA8cmVnZXg+CisjaW5jbHVkZSA8dGVzdHN1aXRlX2hvb2tzLmg+ CisKK3ZvaWQKK3Rlc3QwMSgpCit7CisgIGJvb2wgdGVzdCBfX2F0dHJpYnV0 ZV9fKCh1bnVzZWQpKSA9IHRydWU7CisKKyAgc3RkOjpjbWF0Y2ggbTsKKyAg c3RkOjpyZWdleF9tYXRjaCgiYSIsIG0sIHN0ZDo6cmVnZXgoImEiKSk7Cisg IHN0ZDo6Y21hdGNoIG1tMSA9IG0sIG1tMjsKKyAgbW0xLnN3YXAobW0yKTsK KyAgVkVSSUZZKG0gPT0gbW0yKTsKKyAgc3RkOjpzd2FwKG1tMSwgbW0yKTsK KyAgVkVSSUZZKG0gPT0gbW0xKTsKK30KKworaW50CittYWluKCkKK3sKKyAg dGVzdDAxKCk7CisgIHJldHVybiAwOworfQo= --001a11c11e46ab31ef050c294375--