From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39205 invoked by alias); 15 Feb 2017 07:43:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 39186 invoked by uid 89); 15 Feb 2017 07:43:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=visit X-HELO: mail-oi0-f41.google.com Received: from mail-oi0-f41.google.com (HELO mail-oi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Feb 2017 07:43:30 +0000 Received: by mail-oi0-f41.google.com with SMTP id s203so82837838oie.1 for ; Tue, 14 Feb 2017 23:43:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BJ0YOFcHY/wZkSjoPS3aZdiHOsEEGnYVrDCBWJRNsAc=; b=CiwJ/mXQIOGuORsmwwV3usPShDUPwiymfU9zESmWWAiHYcKhgj6lJaFRsc+P9oSV69 znN5rvQKUl5zBFdydQSkIA4o+hxDKeDjPZrn7aaB5hAMi5iHGv+r1zfZ4/PlH2A1jZ/v FwelC3QXnqOggcDrxQvQlG7UYAJtitgMNrHDIYkYsNlVz9GT5ewR6qIt4rFUr8j0gr4g BlXvLhmIMEAEc7soCEIcDgcQ7+7dIKbacF4LmLMt4W/2Wb/NlS8vxn89jOE4y6aGZ/89 F+QS5J1E/+Bbu/L/aekRbgOkPBnRSf6w1qSGCLXxBqXx3YpIUjBIRYQpazfuwkFbuDt/ 0CmA== X-Gm-Message-State: AMke39l3kRGWFtwlMxLLeV5hiX57GOewIX40a/+VPyhcAsfBgOM5wlMacZB3hhiquequF6TkcXMSQVC9DcSXjuDH X-Received: by 10.202.105.70 with SMTP id e67mr19843860oic.26.1487144608730; Tue, 14 Feb 2017 23:43:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.104.159 with HTTP; Tue, 14 Feb 2017 23:43:28 -0800 (PST) In-Reply-To: <20170214224938.GA4602@redhat.com> References: <20170214224938.GA4602@redhat.com> From: "Tim Shen via gcc-patches" Reply-To: Tim Shen Date: Wed, 15 Feb 2017 08:15:00 -0000 Message-ID: Subject: Re: [PATCH] Fix return type detection in visit() To: Jonathan Wakely Cc: "libstdc++" , gcc-patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2017-02/txt/msg00966.txt.bz2 On Tue, Feb 14, 2017 at 2:49 PM, Jonathan Wakely wrote: > On 14/02/17 13:59 -0800, Tim Shen via libstdc++ wrote: >> >> This is an obvious missing std::forward. :) > > > I was about to look into it, I assumed it would be something simple! > >> diff --git a/libstdc++-v3/testsuite/20_util/variant/compile.cc >> b/libstdc++-v3/testsuite/20_util/variant/compile.cc >> index 65f4326c397..d40a4ccb784 100644 >> --- a/libstdc++-v3/testsuite/20_util/variant/compile.cc >> +++ b/libstdc++-v3/testsuite/20_util/variant/compile.cc >> @@ -291,6 +291,13 @@ void test_visit() >> }; >> static_assert(visit(Visitor(), variant(0)), ""); >> } >> + // PR libstdc++/79513 >> + { >> + std::variant v(5); >> + std::visit([](int&){}, v); >> + std::visit([](int&&){}, std::move(v)); >> + (void)v; > > > Is this to suppress an unused variable warning? > > If it is, please use an attribute instead, as it's more reliable: > > std::variant v __attribute__((unused)) (5); Even better, I used the shiny new [[gnu::unused]]. :) > > OK for trunk if testing passes, thanks. > Tested and committed. -- Regards, Tim Shen