From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 742B83858C5F; Sat, 20 Jan 2024 18:47:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 742B83858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 742B83858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705776433; cv=none; b=qOJLmKtNjHg6oNpbDzwU/RfHmEwyVKFL/O1IpZvkW79h3gWzfG5w/5RE5wl7LAyoK5ySMgOV5E2IZ3c5T/2a6EICZnEXlxo2N8lGFhbdNow1vBWHEiM8Nyymq5DaiUl/bro3d77Mz7+wupt1hWrhdzvD8cVpx+mgHJvchTyFfW4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705776433; c=relaxed/simple; bh=dtPnTia6BdWq/NPtGm1RPgXPNNVGkgK5477CAfV9N2o=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=UdiJTLdqqIBCLzUs/ZjKWBnwitPJBZw4qXHY8vEo1fZdgIAByvmDLKWVtKfoHLAXnKbsAQPQIH7FTVcTx1aeCE0G2mZtNyfZjLL4zmtFdxPKIU9sQI9XvZT+7X7K/79Fsil8IpJLQTt2R29qyZ7X7WfLJlHmMfIJzqZ1lW87cco= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40d6b4e2945so22071225e9.0; Sat, 20 Jan 2024 10:47:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705776429; x=1706381229; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Lc/Q+xdPQ0FJo10Z1EwdV8AB2PODqrd6ZrljmxgJubA=; b=m3upSQafzHQ4oXV/Qk9etVMOeAokx2P7HPK6Z0125DJ3N3d6TBuN2CutLetuZdA/u1 i7k7oRCduc5iwhG0Oua3LXpP2hlEVDJcPZZvrABMoM1PeNH4JyRvZ8sU9GEydjMJ/hKq aY90/PwNgZ4oujP76sCc7wYBFHUh2VWOIKo0BLNj2DW/mvUatpi9OssbPP+47MIcg1gk gy+PqN0xXgeb/Itr0JhI0GMYNd0XYF0t5VkOv7ZQqdVj4nQevsmQiILrgfVvNCNZ+KkI XLaELvloTV+E9PTCd/KDiGv1OwSQgBBESdE3kPwri6bJC5TQWP/gbR7t3kRYCIKckWkz gVAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705776429; x=1706381229; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Lc/Q+xdPQ0FJo10Z1EwdV8AB2PODqrd6ZrljmxgJubA=; b=px2Pm3qniCiJZf2hBjHjoN28zs/XwFU7L7h47TDXQfW68RsjWZ3pmqNU/obvs/KS0d SeeHgGHuOPbXXDvrDt0AWjcLZ7fxnPX3RKkJuIAsxivzVOj4lN8WW4Ua3n/9C+2Jkszi 42F9HOQfsMboNlr453bsUzEa7RT7a0K4rESO6AonRau0oJXVgM7JIlTbHLCudKktMtJF bDnR3KwmBxUvqIma+UJZcijYoJOsZKyFwj5cZ+N+5Jfy0UOSzS2XaFJr+u+rjiMTYkAR vwqmUwd4sjwawKCo0H4LWWpstPQX5+onqO7K+bIaS+APQmuNEUmQ9LSvpKZRdbrcHDwb WzAQ== X-Gm-Message-State: AOJu0YyRwa0AOx+Q2z6EsuXmZN9+ffl+KGmMqWW4H1WT4gPTspRpelTq jW9LYEz/J3SLM5EMagEoBwywRlb8oUDa/qR7J/C5hSjV6C/aMFLPCciax5BZ6vxFtWRbPuylUqg /pswI1+cFXwdFCV0VdT1Xkj0EhZw= X-Google-Smtp-Source: AGHT+IHLkbIjx0/wbvrua8xXhWsPag42M7M7uyRPDiaK7aIpmR0CFAzkl4ITtWesHVVTH9U4j2wZWGOmU9EDa9Sco8c= X-Received: by 2002:a05:600c:3b88:b0:40e:867d:7c27 with SMTP id n8-20020a05600c3b8800b0040e867d7c27mr679248wms.262.1705776428830; Sat, 20 Jan 2024 10:47:08 -0800 (PST) MIME-Version: 1.0 References: <55ac674d-468c-d4f5-e45e-190b25202412@gmx.de> In-Reply-To: From: Alexander Westbrooks Date: Sat, 20 Jan 2024 12:46:57 -0600 Message-ID: Subject: Re: PR82943 - Suggested patch to fix To: Harald Anlauf Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="0000000000001b5a18060f650693" X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000001b5a18060f650693 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello and Happy New Year! I wanted to follow up on this patch I made to address PR82943 for GFortran. Has anyone had a chance to review it? Thanks, Alexander Westbrooks On Thu, Jun 29, 2023 at 10:38=E2=80=AFPM Alexander Westbrooks wrote: > Hello, > > I have finished my testing, and updated my patch and relevant Changelogs. > I added 4 new tests and all the existing tests in the current testsuite > for gfortran passed or failed as expected. Do I need to attach the test > results here? > > The platform I tested on was a Docker container running in Docker Desktop, > running the "mcr.microsoft.com/devcontainers/universal:2-linux" image. > > I also made sure that my code changes followed the coding standards. > Please let me know if there is anything else that I need to do. I don't > have write-access to the repository. > > Thanks, > > Alexander > > On Wed, Jun 28, 2023 at 4:14=E2=80=AFPM Harald Anlauf wro= te: > >> Hi Alex, >> >> welcome to the gfortran community. It is great that you are trying >> to get actively involved. >> >> You already did quite a few things right: patches shall be sent to >> the gcc-patches ML, but Fortran reviewers usually notice them only >> where they are copied to the fortran ML. >> >> There are some general recommendations on the formatting of C code, >> like indentation, of the patches, and of the commit log entries. >> >> Regarding coding standards, see https://www.gnu.org/prep/standards/ . >> >> Regarding testcases, a recommendation is to have a look at >> existing testcases, e.g. in gcc/testsuite/gfortran.dg/, and then >> decide if the testcase shall test the compile-time or run-time >> behaviour, and add the necessary dejagnu directives. >> >> You should also verify if your patch passes regression testing. >> For changes to gfortran, it is usually sufficient to run >> >> make check-fortran -j >> >> where is the number of parallel tests. >> You would need to report also the platform where you tested on. >> >> There is also a legal issue to consider before non-trivial patches can >> be accepted for incorporation: https://gcc.gnu.org/contribute.html#legal >> >> If your patch is accepted and if you do not have write-access to the >> repository, one of the maintainers will likely take care of it. >> If you become a regular contributor, you will probably want to consider >> getting write access. >> >> Cheers, >> Harald >> >> >> >> On 6/24/23 19:17, Alexander Westbrooks via Gcc-patches wrote: >> > Hello, >> > >> > I am new to the GFortran community. Over the past two weeks I created a >> > patch that should fix PR82943 for GFortran. I have attached it to this >> > email. The patch allows the code below to compile successfully. I am >> > working on creating test cases next, but I am new to the process so it >> may >> > take me some time. After I make test cases, do I email them to you as >> well? >> > Do I need to make a pull-request on github in order to get the patch >> > reviewed? >> > >> > Thank you, >> > >> > Alexander Westbrooks >> > >> > module testmod >> > >> > public :: foo >> > >> > type, public :: tough_lvl_0(a, b) >> > integer, kind :: a =3D 1 >> > integer, len :: b >> > contains >> > procedure :: foo >> > end type >> > >> > type, public, EXTENDS(tough_lvl_0) :: tough_lvl_1 (c) >> > integer, len :: c >> > contains >> > procedure :: bar >> > end type >> > >> > type, public, EXTENDS(tough_lvl_1) :: tough_lvl_2 (d) >> > integer, len :: d >> > contains >> > procedure :: foobar >> > end type >> > >> > contains >> > subroutine foo(this) >> > class(tough_lvl_0(1,*)), intent(inout) :: this >> > end subroutine >> > >> > subroutine bar(this) >> > class(tough_lvl_1(1,*,*)), intent(inout) :: this >> > end subroutine >> > >> > subroutine foobar(this) >> > class(tough_lvl_2(1,*,*,*)), intent(inout) :: this >> > end subroutine >> > >> > end module >> > >> > PROGRAM testprogram >> > USE testmod >> > >> > TYPE(tough_lvl_0(1,5)) :: test_pdt_0 >> > TYPE(tough_lvl_1(1,5,6)) :: test_pdt_1 >> > TYPE(tough_lvl_2(1,5,6,7)) :: test_pdt_2 >> > >> > CALL test_pdt_0%foo() >> > >> > CALL test_pdt_1%foo() >> > CALL test_pdt_1%bar() >> > >> > CALL test_pdt_2%foo() >> > CALL test_pdt_2%bar() >> > CALL test_pdt_2%foobar() >> > >> > >> > END PROGRAM testprogram >> >> --0000000000001b5a18060f650693--