From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id 09C963858D3C; Mon, 10 Jul 2023 05:33:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09C963858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-il1-x132.google.com with SMTP id e9e14a558f8ab-345d6dc271dso22297005ab.0; Sun, 09 Jul 2023 22:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688967186; x=1691559186; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Lgv1TX8bqJfkf+sDAEEaCPRtHRb/h2Pi/Og6FJojEc8=; b=AAK3NW1hgh4i1ifhAHBXG+At6rK/VENxSTTp+gwLV2W9lbhMLaC9JXqvipB45TbVvb sZ8L5pXgGPcNhtBuNAFIVAjD2pr5VoG1F5IB/7aCsCEV3D/5Z0KLQVKig2cJu3x8SOMB ue3mb4dAUwSHCnKHLk0c2/fIZRnYlTbBtCJOROQuWsqPxxsb4LUllDrK0k5nmZdBe1x4 n4SKMOMl7xesYqvCDnbQGlc/+u70uUYt3IUPkm6u0OdkkmZ6sI2X6iE4QE8jAQqJiMq0 oyIp/g08VWd4eN710OvzYxE6NYcfVYt2MeDmdU2FwRN1zWV/JsmnBcryMzviyb58Y0Tq JI4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688967186; x=1691559186; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Lgv1TX8bqJfkf+sDAEEaCPRtHRb/h2Pi/Og6FJojEc8=; b=RLqb5hxgT90V/JqGkRhdmR7ogVeIO994/9yNdV0cBKJwIIUiq1Pa1SzNjh3DN/iB9H nas26HU4mGyytF/vv64PdsOx87Z5/Lii4mWF2nD9c6slcX3ah0Fugizjds+XN7W/jvDR jovr4/hebpTCZB1xNpWgcC+RErkIHSqT04yx2s6i/hcdsnmKorlyhyC4xEQr5nu32955 uoB5t2jusvB7+/9zQE5lBB/SLJIZmqRuNPRiKZrW3xXOLn2rnMixH/xwPdq9wUVmWB4M RLimzc7Qx+HxF+2ulHj3XSAaOXH0wNKeRkIXy9tIt8Bx2F+/Ycd3Qu7QDrCDjwA2hkhY NoYA== X-Gm-Message-State: ABy/qLa7BbyYTy1gMiPgYQRyf39Lm4aGWBnI1jfLK3DQPYx4WDtYetIB xAuCbwme5OykHv2j90ki/5GEZupqhRo5OZYy9UDvZbHqDh4= X-Google-Smtp-Source: APBJJlGlzyOAxPYJ7/l9tT/TgMiYU2ntjH0aAJtCpjfBiFfxs9kIqFw1YZFe1Eed4hiX9MS3A2TxurOjfKN+KKg4xdk= X-Received: by 2002:a92:cec9:0:b0:340:aac2:6908 with SMTP id z9-20020a92cec9000000b00340aac26908mr10468590ilq.2.1688967186077; Sun, 09 Jul 2023 22:33:06 -0700 (PDT) MIME-Version: 1.0 References: <20230710052310.48116-1-kmatsui@gcc.gnu.org> <20230710052310.48116-2-kmatsui@gcc.gnu.org> In-Reply-To: <20230710052310.48116-2-kmatsui@gcc.gnu.org> From: =?UTF-8?Q?Daniel_Kr=C3=BCgler?= Date: Mon, 10 Jul 2023 07:32:55 +0200 Message-ID: Subject: Re: [PATCH 2/2] libstdc++: use new built-in trait __is_pointer To: Ken Matsui Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am Mo., 10. Juli 2023 um 07:24 Uhr schrieb Ken Matsui via Libstdc++ : > > This patch lets libstdc++ use new built-in trait __is_pointer. > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (is_pointer): Use __is_pointer > built-in trait. > (is_pointer_v): Likewise. > > Signed-off-by: Ken Matsui > --- > libstdc++-v3/include/std/type_traits | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > index 0e7a9c9c7f3..d83db98403b 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -515,6 +515,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > struct is_array<_Tp[]> > : public true_type { }; > > + /// is_pointer > +#if __has_builtin(__is_pointer) > + template > + struct is_pointer > + : public __bool_constant<__is_pointer(_Tp)> > + { }; > +#else > template > struct __is_pointer_helper > : public false_type { }; > @@ -523,11 +530,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > struct __is_pointer_helper<_Tp*> > : public true_type { }; > > - /// is_pointer > template > struct is_pointer > : public __is_pointer_helper<__remove_cv_t<_Tp>>::type > { }; > +#endif > > /// is_lvalue_reference > template > -- > 2.41.0 Shouldn't this adjust is_pointer_v as well? Thanks, - Daniel